Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8326117: ProblemList serviceability/jvmti/vthread/SuspendWithInterruptLock/SuspendWithInterruptLock.java#default in Xcomp mode #17904

Closed
wants to merge 2 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Feb 18, 2024

Trivial fixes to ProblemList a couple of tests:
JDK-8326117 ProblemList serviceability/jvmti/vthread/SuspendWithInterruptLock/SuspendWithInterruptLock.java#default in Xcomp mode
JDK-8326120 ProblemList sun/java2d/X11SurfaceData/SharedMemoryPixmapsTest/SharedMemoryPixmapsTest.sh on macosx-aarch64


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8326117: ProblemList serviceability/jvmti/vthread/SuspendWithInterruptLock/SuspendWithInterruptLock.java#default in Xcomp mode (Sub-task - P3)
  • JDK-8326120: ProblemList sun/java2d/X11SurfaceData/SharedMemoryPixmapsTest/SharedMemoryPixmapsTest.sh on macosx-aarch64 (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17904/head:pull/17904
$ git checkout pull/17904

Update a local copy of the PR:
$ git checkout pull/17904
$ git pull https://git.openjdk.org/jdk.git pull/17904/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17904

View PR using the GUI difftool:
$ git pr show -t 17904

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17904.diff

Webrev

Link to Webrev Comment

…tLock/SuspendWithInterruptLock.java#default in Xcomp mode
@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add serviceability

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 18, 2024

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Feb 18, 2024
@openjdk
Copy link

openjdk bot commented Feb 18, 2024

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Feb 18, 2024
@openjdk
Copy link

openjdk bot commented Feb 18, 2024

@dcubed-ojdk
The serviceability label was successfully added.

…t/SharedMemoryPixmapsTest.sh on macosx-aarch64
@dcubed-ojdk
Copy link
Member Author

/issue JDK-8326117
/issue JDK-8326120

/label add client

@openjdk
Copy link

openjdk bot commented Feb 18, 2024

@dcubed-ojdk This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

openjdk bot commented Feb 18, 2024

@dcubed-ojdk
Adding additional issue to issue list: 8326120: ProblemList sun/java2d/X11SurfaceData/SharedMemoryPixmapsTest/SharedMemoryPixmapsTest.sh on macosx-aarch64.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Feb 18, 2024
@openjdk
Copy link

openjdk bot commented Feb 18, 2024

@dcubed-ojdk
The client label was successfully added.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review February 18, 2024 15:46
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 18, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 18, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 18, 2024

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326117: ProblemList serviceability/jvmti/vthread/SuspendWithInterruptLock/SuspendWithInterruptLock.java#default in Xcomp mode
8326120: ProblemList sun/java2d/X11SurfaceData/SharedMemoryPixmapsTest/SharedMemoryPixmapsTest.sh on macosx-aarch64

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 39627bc: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize()
  • 7004c27: 8303972: (zipfs) Make test/jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java independent of the zip command line

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 18, 2024
@dcubed-ojdk
Copy link
Member Author

@AlanBateman - Thanks for the review! Especially on a Sunday!!

@dcubed-ojdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 18, 2024

Going to push as commit 099b744.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 39627bc: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize()
  • 7004c27: 8303972: (zipfs) Make test/jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java independent of the zip command line

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 18, 2024
@openjdk openjdk bot closed this Feb 18, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 18, 2024
@openjdk
Copy link

openjdk bot commented Feb 18, 2024

@dcubed-ojdk Pushed as commit 099b744.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8326117 branch February 18, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants