-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8326117: ProblemList serviceability/jvmti/vthread/SuspendWithInterruptLock/SuspendWithInterruptLock.java#default in Xcomp mode #17904
Conversation
…tLock/SuspendWithInterruptLock.java#default in Xcomp mode
/label add hotspot-runtime |
👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into |
@dcubed-ojdk |
@dcubed-ojdk |
…t/SharedMemoryPixmapsTest.sh on macosx-aarch64
/issue JDK-8326117 /label add client |
@dcubed-ojdk This issue is referenced in the PR title - it will now be updated. |
@dcubed-ojdk |
@dcubed-ojdk |
@dcubed-ojdk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
@AlanBateman - Thanks for the review! Especially on a Sunday!! |
/integrate |
Going to push as commit 099b744.
Your commit was automatically rebased without conflicts. |
@dcubed-ojdk Pushed as commit 099b744. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Trivial fixes to ProblemList a couple of tests:
JDK-8326117 ProblemList serviceability/jvmti/vthread/SuspendWithInterruptLock/SuspendWithInterruptLock.java#default in Xcomp mode
JDK-8326120 ProblemList sun/java2d/X11SurfaceData/SharedMemoryPixmapsTest/SharedMemoryPixmapsTest.sh on macosx-aarch64
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17904/head:pull/17904
$ git checkout pull/17904
Update a local copy of the PR:
$ git checkout pull/17904
$ git pull https://git.openjdk.org/jdk.git pull/17904/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 17904
View PR using the GUI difftool:
$ git pr show -t 17904
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17904.diff
Webrev
Link to Webrev Comment