-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8326127: JFR: Add SafepointCleanupTask to hardToTestEvents of TestLookForUntestedEvents #17907
Conversation
…kForUntestedEvents
👋 Welcome back ddong! A progress list of the required criteria for merging this PR into |
@D-D-H This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks for the review. /integrate |
Going to push as commit 9fbcc00.
Your commit was automatically rebased without conflicts. |
Greetings,
JDK-8322630 made the
EventSafepointCleanupTask
hard to test. We'd better move it to hardToTestEvents of TestLookForUntestedEvents instead of commenting out it.Denghui
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17907/head:pull/17907
$ git checkout pull/17907
Update a local copy of the PR:
$ git checkout pull/17907
$ git pull https://git.openjdk.org/jdk.git pull/17907/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 17907
View PR using the GUI difftool:
$ git pr show -t 17907
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17907.diff
Webrev
Link to Webrev Comment