Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8326127: JFR: Add SafepointCleanupTask to hardToTestEvents of TestLookForUntestedEvents #17907

Closed
wants to merge 1 commit into from

Conversation

D-D-H
Copy link
Contributor

@D-D-H D-D-H commented Feb 19, 2024

Greetings,

JDK-8322630 made the EventSafepointCleanupTask hard to test. We'd better move it to hardToTestEvents of TestLookForUntestedEvents instead of commenting out it.

Denghui


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8326127: JFR: Add SafepointCleanupTask to hardToTestEvents of TestLookForUntestedEvents (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17907/head:pull/17907
$ git checkout pull/17907

Update a local copy of the PR:
$ git checkout pull/17907
$ git pull https://git.openjdk.org/jdk.git pull/17907/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17907

View PR using the GUI difftool:
$ git pr show -t 17907

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17907.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 19, 2024

👋 Welcome back ddong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 19, 2024
@openjdk
Copy link

openjdk bot commented Feb 19, 2024

@D-D-H The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Feb 19, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 19, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 19, 2024

@D-D-H This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326127: JFR: Add SafepointCleanupTask to hardToTestEvents of TestLookForUntestedEvents

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • b366492: 8326152: Bad copyright header in test/jdk/java/util/zip/DeflaterDictionaryTests.java
  • 9451677: 8326100: DeflaterDictionaryTests should use Deflater.getBytesWritten instead of Deflater.getTotalOut
  • d422811: 8324630: C1: Canonicalizer::do_LookupSwitch doesn't break the loop when the successor is found
  • 3742bc6: 8323795: jcmd Compiler.codecache should print total size of code cache
  • 099b744: 8326117: ProblemList serviceability/jvmti/vthread/SuspendWithInterruptLock/SuspendWithInterruptLock.java#default in Xcomp mode
  • 39627bc: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize()
  • 7004c27: 8303972: (zipfs) Make test/jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java independent of the zip command line

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 19, 2024
@D-D-H
Copy link
Contributor Author

D-D-H commented Feb 20, 2024

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Feb 20, 2024

Going to push as commit 9fbcc00.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 7d32a1a: 8326111: JFR: Cleanup for JFR_ONLY
  • a3d7f9f: 8326126: Update the java manpage with the changes from JDK-8322478
  • 20a25f6: 8326067: Remove os::remap_memory and simplify os::map_memory
  • 5c5a282: 8325950: Make sure all files in the JDK pass jcheck
  • 8668198: 8325972: Add -x to bash for building with LOG=debug
  • a19314b: 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space
  • f6d7e30: 8294977: Convert test/jdk/java tests from ASM library to Classfile API
  • 82609b1: 8326112: Javadoc snippet for Linker.Option.captureCallState is wrong
  • a776104: 8326106: Write and clear stack trace table outside of safepoint
  • 56c5084: 8307246: Printing: banded raster path doesn't account for device offset values
  • ... and 9 more: https://git.openjdk.org/jdk/compare/c2d9fa26ce903be7c86a47db5ff289cdb9de3a62...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 20, 2024
@openjdk openjdk bot closed this Feb 20, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 20, 2024
@openjdk
Copy link

openjdk bot commented Feb 20, 2024

@D-D-H Pushed as commit 9fbcc00.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants