Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258447: Move make/hotspot/hotspot.script to make/scripts #1791

Closed
wants to merge 1 commit into from

Conversation

@magicus
Copy link
Member

@magicus magicus commented Dec 15, 2020

The hotspot launcher script is misplaced among the hotspot make files. It should move to make/scripts (and get a proper extension).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258447: Move make/hotspot/hotspot.script to make/scripts

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1791/head:pull/1791
$ git checkout pull/1791

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 15, 2020

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Dec 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 15, 2020

@magicus The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the build label Dec 15, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 15, 2020

Webrevs

Loading

@magicus
Copy link
Member Author

@magicus magicus commented Dec 15, 2020

/label add hotspot

Loading

@openjdk openjdk bot added the hotspot label Dec 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 15, 2020

@magicus
The hotspot label was successfully added.

Loading

@magicus
Copy link
Member Author

@magicus magicus commented Dec 16, 2020

Can someone from hotspot please confirm if this script is still needed/used?

Loading

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

The rename and makefile changes look good.
I've used the script on occasion, but not recently (not in the last 6 months).

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Dec 16, 2020

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258447: Move make/hotspot/hotspot.script to make/scripts

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 6eca296: 8258420: Move URL configuration from Docs.gmk to conf dir
  • 3c66485: 8257906: JFR: RecordingStream leaks memory
  • 0c8cc2c: 8258058: improve description of OutOfMemoryError relevant flags
  • cdb5342: 8258252: Move PtrQueue enqueue to PtrQueueSet subclasses
  • 17ace83: 8258074: Move some flags related to compiler to compiler_globals.hpp
  • 47ba652: 8258455: problem list tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java
  • 1e77896: 8236225: Remove expired flags in JDK 17
  • 4d6f318: 8257726: Make -XX:+StressLdcRewrite option a diagnostic option

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Dec 16, 2020
@magicus
Copy link
Member Author

@magicus magicus commented Dec 16, 2020

/integrate

Loading

@openjdk openjdk bot closed this Dec 16, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 16, 2020

@magicus Since your change was applied there have been 9 commits pushed to the master branch:

  • 70183f4: 8251438: Issues with our POSIX set_signal_handler()
  • 6eca296: 8258420: Move URL configuration from Docs.gmk to conf dir
  • 3c66485: 8257906: JFR: RecordingStream leaks memory
  • 0c8cc2c: 8258058: improve description of OutOfMemoryError relevant flags
  • cdb5342: 8258252: Move PtrQueue enqueue to PtrQueueSet subclasses
  • 17ace83: 8258074: Move some flags related to compiler to compiler_globals.hpp
  • 47ba652: 8258455: problem list tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java
  • 1e77896: 8236225: Remove expired flags in JDK 17
  • 4d6f318: 8257726: Make -XX:+StressLdcRewrite option a diagnostic option

Your commit was automatically rebased without conflicts.

Pushed as commit ab5d581.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@magicus magicus deleted the move-hotspot-script branch Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants