8258058: improve description of OutOfMemoryError relevant flags

[navyxliu]

/cc hotspot

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8258058: improve description of OutOfMemoryError relevant flags

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Jie Fu (@DamonFool - Committer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1792/head:pull/1792
$ git checkout pull/1792

[bridgekeeper]

👋 Welcome back xliu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@navyxliu
The hotspot label was successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (599bea8)
• 00: Full (f8c225d)

[navyxliu]

/summary OutOfMemoryError thrown out of JVM doesn't notify hotspot, so debug.cpp::report_java_out_out_memory does not handle it. ie. Some options don't respect OOMEs from Java libraries. We need to make the description more clear to users.

[openjdk]

@navyxliu Setting summary to OutOfMemoryError thrown out of JVM doesn't notify hotspot, so debug.cpp::report_java_out_out_memory does not handle it. ie. Some options don't respect OOMEs from Java libraries. We need to make the description more clear to users.

[dholmes-ora]

Seems fine.

Thanks,
David

[openjdk]

@navyxliu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258058: improve description of OutOfMemoryError relevant flags

OutOfMemoryError thrown out of JVM doesn't notify hotspot, so debug.cpp::report_java_out_out_memory does not handle it. ie. Some options don't respect OOMEs from Java libraries.  We need to make the description more clear to users.

Reviewed-by: dholmes, jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• cdb5342: 8258252: Move PtrQueue enqueue to PtrQueueSet subclasses
• 17ace83: 8258074: Move some flags related to compiler to compiler_globals.hpp
• 47ba652: 8258455: problem list tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java
• 1e77896: 8236225: Remove expired flags in JDK 17
• 4d6f318: 8257726: Make -XX:+StressLdcRewrite option a diagnostic option

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora, @DamonFool) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[DamonFool]

It would be better to align \ to the right.

[navyxliu]

yes, thanks!

[DamonFool]

Thanks for the change.

LGTM

[navyxliu]

/integrate

[openjdk]

@navyxliu
Your change (at version 599bea8) is now ready to be sponsored by a Committer.

[DamonFool]

/sponsor

[openjdk]

@DamonFool @navyxliu Since your change was applied there have been 5 commits pushed to the master branch:

• cdb5342: 8258252: Move PtrQueue enqueue to PtrQueueSet subclasses
• 17ace83: 8258074: Move some flags related to compiler to compiler_globals.hpp
• 47ba652: 8258455: problem list tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java
• 1e77896: 8236225: Remove expired flags in JDK 17
• 4d6f318: 8257726: Make -XX:+StressLdcRewrite option a diagnostic option

Your commit was automatically rebased without conflicts.

Pushed as commit 0c8cc2c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[navyxliu]

Thanks! @DamonFool and @dholmes-ora