Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258058: improve description of OutOfMemoryError relevant flags #1792

Closed
wants to merge 2 commits into from

Conversation

navyxliu
Copy link
Member

@navyxliu navyxliu commented Dec 15, 2020

/cc hotspot


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258058: improve description of OutOfMemoryError relevant flags

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1792/head:pull/1792
$ git checkout pull/1792

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 15, 2020

👋 Welcome back xliu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr hotspot labels Dec 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 15, 2020

@navyxliu
The hotspot label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 15, 2020

Webrevs

@navyxliu
Copy link
Member Author

@navyxliu navyxliu commented Dec 15, 2020

/summary OutOfMemoryError thrown out of JVM doesn't notify hotspot, so debug.cpp::report_java_out_out_memory does not handle it. ie. Some options don't respect OOMEs from Java libraries. We need to make the description more clear to users.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 15, 2020

@navyxliu Setting summary to OutOfMemoryError thrown out of JVM doesn't notify hotspot, so debug.cpp::report_java_out_out_memory does not handle it. ie. Some options don't respect OOMEs from Java libraries. We need to make the description more clear to users.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Seems fine.

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented Dec 16, 2020

@navyxliu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258058: improve description of OutOfMemoryError relevant flags

OutOfMemoryError thrown out of JVM doesn't notify hotspot, so debug.cpp::report_java_out_out_memory does not handle it. ie. Some options don't respect OOMEs from Java libraries.  We need to make the description more clear to users.

Reviewed-by: dholmes, jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • cdb5342: 8258252: Move PtrQueue enqueue to PtrQueueSet subclasses
  • 17ace83: 8258074: Move some flags related to compiler to compiler_globals.hpp
  • 47ba652: 8258455: problem list tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java
  • 1e77896: 8236225: Remove expired flags in JDK 17
  • 4d6f318: 8257726: Make -XX:+StressLdcRewrite option a diagnostic option

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora, @DamonFool) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Dec 16, 2020
@@ -550,7 +551,8 @@ const intx ObjectAlignmentInBytes = 8;
"Dump heap to file after any major stop-the-world GC") \
\
product(bool, HeapDumpOnOutOfMemoryError, false, MANAGEABLE, \
"Dump heap to file when java.lang.OutOfMemoryError is thrown") \
"Dump heap to file when java.lang.OutOfMemoryError is thrown " \
"from JVM") \
Copy link
Member

@DamonFool DamonFool Dec 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to align \ to the right.

Copy link
Member Author

@navyxliu navyxliu Dec 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, thanks!

Copy link
Member

@DamonFool DamonFool left a comment

Thanks for the change.

LGTM

@navyxliu
Copy link
Member Author

@navyxliu navyxliu commented Dec 16, 2020

/integrate

@openjdk openjdk bot added the sponsor label Dec 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 16, 2020

@navyxliu
Your change (at version 599bea8) is now ready to be sponsored by a Committer.

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Dec 16, 2020

/sponsor

@openjdk openjdk bot closed this Dec 16, 2020
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Dec 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 16, 2020

@DamonFool @navyxliu Since your change was applied there have been 5 commits pushed to the master branch:

  • cdb5342: 8258252: Move PtrQueue enqueue to PtrQueueSet subclasses
  • 17ace83: 8258074: Move some flags related to compiler to compiler_globals.hpp
  • 47ba652: 8258455: problem list tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java
  • 1e77896: 8236225: Remove expired flags in JDK 17
  • 4d6f318: 8257726: Make -XX:+StressLdcRewrite option a diagnostic option

Your commit was automatically rebased without conflicts.

Pushed as commit 0c8cc2c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@navyxliu
Copy link
Member Author

@navyxliu navyxliu commented Dec 16, 2020

Thanks! @DamonFool and @dholmes-ora

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot integrated
3 participants