Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space #17922

Closed
wants to merge 3 commits into from

Conversation

offamitkumar
Copy link
Member

@offamitkumar offamitkumar commented Feb 20, 2024

s390 port similar to e834a48 and updates

  • ArrayCopyStub::emit_code
  • HandlerImpl::emit_exception_handler
  • HandlerImpl::emit_deopt_handler

Testing {fastdebug, release} X {tier1}


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17922/head:pull/17922
$ git checkout pull/17922

Update a local copy of the PR:
$ git checkout pull/17922
$ git pull https://git.openjdk.org/jdk.git pull/17922/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17922

View PR using the GUI difftool:
$ git pr show -t 17922

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17922.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 20, 2024

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title JDK-8326201 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space Feb 20, 2024
@openjdk
Copy link

openjdk bot commented Feb 20, 2024

@offamitkumar The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Feb 20, 2024
@offamitkumar offamitkumar marked this pull request as ready for review February 20, 2024 11:25
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 20, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 20, 2024

Webrevs

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Feb 20, 2024

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space

Reviewed-by: lucy, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • d31fd78: 8325496: Make TrimNativeHeapInterval a product switch
  • 27003b5: 8326090: Rename jvmti_aod.h
  • 36246c9: 8326233: Utils#copySSLParameters loses needClientAuth Setting
  • 14f9aba: 8326371: [BACKOUT] Clean up NativeCompilation.gmk and its newly created parts
  • 1bd91cd: 8325963: Clean up NativeCompilation.gmk and its newly created parts
  • 4d50ee6: 8326368: compare.sh -2bins prints ugly errors on Windows
  • 221fbfb: 8320002: Remove obsolete CDS check in Reflection::verify_class_access()
  • d2590c6: 8325730: StringBuilder.toString allocation for the empty String
  • aa792ea: 8164094: javadoc allows to create a @link to a non-existent method
  • a2d027e: 8326089: Text incorrectly placed in breadcrumbs list in generated docs
  • ... and 9 more: https://git.openjdk.org/jdk/compare/69a11c7f7ea7c4195a8ee56391bdf04c75bd8156...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 20, 2024
@offamitkumar
Copy link
Member Author

@TheRealMDoerr would you please review this as well.

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@offamitkumar
Copy link
Member Author

Thanks for the reviews @RealLucy @TheRealMDoerr.

/integrate

@openjdk
Copy link

openjdk bot commented Feb 21, 2024

Going to push as commit d5f3d5c.
Since your change was applied there have been 19 commits pushed to the master branch:

  • d31fd78: 8325496: Make TrimNativeHeapInterval a product switch
  • 27003b5: 8326090: Rename jvmti_aod.h
  • 36246c9: 8326233: Utils#copySSLParameters loses needClientAuth Setting
  • 14f9aba: 8326371: [BACKOUT] Clean up NativeCompilation.gmk and its newly created parts
  • 1bd91cd: 8325963: Clean up NativeCompilation.gmk and its newly created parts
  • 4d50ee6: 8326368: compare.sh -2bins prints ugly errors on Windows
  • 221fbfb: 8320002: Remove obsolete CDS check in Reflection::verify_class_access()
  • d2590c6: 8325730: StringBuilder.toString allocation for the empty String
  • aa792ea: 8164094: javadoc allows to create a @link to a non-existent method
  • a2d027e: 8326089: Text incorrectly placed in breadcrumbs list in generated docs
  • ... and 9 more: https://git.openjdk.org/jdk/compare/69a11c7f7ea7c4195a8ee56391bdf04c75bd8156...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 21, 2024
@openjdk openjdk bot closed this Feb 21, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 21, 2024
@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@offamitkumar Pushed as commit d5f3d5c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@offamitkumar offamitkumar deleted the 8326201_bailout_v0 branch May 15, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants