-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space #17922
Conversation
👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into |
@offamitkumar The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@offamitkumar This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 19 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@TheRealMDoerr would you please review this as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for the reviews @RealLucy @TheRealMDoerr. /integrate |
Going to push as commit d5f3d5c.
Your commit was automatically rebased without conflicts. |
@offamitkumar Pushed as commit d5f3d5c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
s390 port similar to e834a48 and updates
Testing
{fastdebug, release} X {tier1}
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17922/head:pull/17922
$ git checkout pull/17922
Update a local copy of the PR:
$ git checkout pull/17922
$ git pull https://git.openjdk.org/jdk.git pull/17922/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 17922
View PR using the GUI difftool:
$ git pr show -t 17922
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17922.diff
Webrev
Link to Webrev Comment