Skip to content

8326334: JFR failed assert(used(klass)) failed: invariant #17934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mgronlun wants to merge 3 commits into from
Closed

8326334: JFR failed assert(used(klass)) failed: invariant #17934

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb1a113
fix for JFR sampler by adding all unloading classes
mgronlun Feb 17, 2024
5ef1936
8326334
mgronlun Feb 20, 2024
3993ae8
space
mgronlun Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/hotspot/share/jfr/support/jfrKlassUnloading.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2020, 2023, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2020, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -101,13 +101,12 @@ void JfrKlassUnloading::clear() {
}
}

static bool add_to_unloaded_klass_set(traceid klass_id, bool current_epoch) {
static void add_to_unloaded_klass_set(traceid klass_id) {
assert_locked_or_safepoint(ClassLoaderDataGraph_lock);
GrowableArray<traceid>* const unload_set = current_epoch ? get_unload_set() : get_unload_set_previous_epoch();
GrowableArray<traceid>* const unload_set = get_unload_set();
assert(unload_set != nullptr, "invariant");
assert(unload_set->find(klass_id) == -1, "invariant");
unload_set->append(klass_id);
return true;
}

#if INCLUDE_MANAGEMENT
Expand All @@ -129,7 +128,8 @@ bool JfrKlassUnloading::on_unload(const Klass* k) {
if (IS_JDK_JFR_EVENT_SUBKLASS(k)) {
++event_klass_unloaded_count;
}
return USED_ANY_EPOCH(k) && add_to_unloaded_klass_set(JfrTraceId::load_raw(k), USED_THIS_EPOCH(k));
add_to_unloaded_klass_set(JfrTraceId::load_raw(k));
return USED_THIS_EPOCH(k);
}

bool JfrKlassUnloading::is_unloaded(traceid klass_id, bool previous_epoch /* false */) {
Expand Down