8326368: compare.sh -2bins prints ugly errors on Windows

[magicus]

The logic in the compare script assumes that we compare two directories, and so always have an $OTHER. If we are using -2dirs, this is not the case, causing cygpath and the following ls to fail and print error messages about missing paths. These are benign but annoying.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8326368: compare.sh -2bins prints ugly errors on Windows (Bug - P4)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17936/head:pull/17936
$ git checkout pull/17936

Update a local copy of the PR:
$ git checkout pull/17936
$ git pull https://git.openjdk.org/jdk.git pull/17936/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17936

View PR using the GUI difftool:
$ git pr show -t 17936

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17936.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@magicus The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (90f0bd53)

[openjdk]

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326368: compare.sh -2bins prints ugly errors on Windows

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 63 new commits pushed to the master branch:

• d2590c6: 8325730: StringBuilder.toString allocation for the empty String
• aa792ea: 8164094: javadoc allows to create a @link to a non-existent method
• a2d027e: 8326089: Text incorrectly placed in breadcrumbs list in generated docs
• b419e95: 8294148: Support JSplitPane for instructions and test UI
• 9538f5d: 8319651: Several network tests ignore vm flags when start java process
• 4957d6a: 8325441: IGV: update pom.xml such that IntelliJ can import as maven project
• d60331a: 8326196: Serial: Remove SerialHeap::generation_iterate
• beed414: 8326209: G1: Remove G1ConcurrentMark::_total_cleanup_time
• 56073cd: 8326171: Serial: Remove VerifyGCLevel
• bb675af: 8325542: CTW: Runner can produce negative StressSeed
• ... and 53 more: https://git.openjdk.org/jdk/compare/0d51b76947324643166cdaf9ca703431bd83bc0e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[magicus]

/integrate

[openjdk]

Going to push as commit 4d50ee6.
Since your change was applied there have been 64 commits pushed to the master branch:

• 221fbfb: 8320002: Remove obsolete CDS check in Reflection::verify_class_access()
• d2590c6: 8325730: StringBuilder.toString allocation for the empty String
• aa792ea: 8164094: javadoc allows to create a @link to a non-existent method
• a2d027e: 8326089: Text incorrectly placed in breadcrumbs list in generated docs
• b419e95: 8294148: Support JSplitPane for instructions and test UI
• 9538f5d: 8319651: Several network tests ignore vm flags when start java process
• 4957d6a: 8325441: IGV: update pom.xml such that IntelliJ can import as maven project
• d60331a: 8326196: Serial: Remove SerialHeap::generation_iterate
• beed414: 8326209: G1: Remove G1ConcurrentMark::_total_cleanup_time
• 56073cd: 8326171: Serial: Remove VerifyGCLevel
• ... and 54 more: https://git.openjdk.org/jdk/compare/0d51b76947324643166cdaf9ca703431bd83bc0e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@magicus Pushed as commit 4d50ee6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.