8314250: CDS dump error message: Invoker type parameter must start and end with Object: L3I_L

[calvinccheung]

While generating holder classes (in generateHolderClasses()), don't add the MethodType to the invokerTypes if will fail the check in the build() method which would result in a RuntimeException.

Also updated the MethodHandlesInvokersTest.java under appcds/methodHandles and appcds/dynamicArchive/methodHandles to check that the "Failed to generate LambdaForm holder classes" error is not in the output;

Passed tiers 1 - 3 testing.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8314250: CDS dump error message: Invoker type parameter must start and end with Object: L3I_L (Bug - P4)

Reviewers

• Ioi Lam (@iklam - Reviewer) ⚠️ Review applies to 38d64c10
• Matias Saavedra Silva (@matias9927 - Committer) ⚠️ Review applies to 38d64c10

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17953/head:pull/17953
$ git checkout pull/17953

Update a local copy of the PR:
$ git checkout pull/17953
$ git pull https://git.openjdk.org/jdk.git pull/17953/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17953

View PR using the GUI difftool:
$ git pr show -t 17953

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17953.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@calvinccheung The following labels will be automatically applied to this pull request:

• core-libs
• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (544fa10e)
• 01: Full - Incremental (38d64c10)
• 00: Full (092171f2)

[iklam]

Looks good. Just a small nit.

[iklam]

This line can be removed.

[calvinccheung]

Fixed.

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314250: CDS dump error message: Invoker type parameter must start and end with Object: L3I_L

Reviewed-by: iklam, matsaave

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 116 new commits pushed to the master branch:

• 0a6e64e: 8327424: ProblemList serviceability/sa/TestJmapCore.java on all platforms with ZGC
• c65d308: 8327812: JFR: Remove debug message in Function.Maximum
• b9bc31f: 8327790: Improve javadoc for ResolvedJavaType.hasFinalizableSubclass
• 18de932: 8325991: Accelerate Poly1305 on x86_64 using AVX2 instructions
• d74b907: 8327093: Add truncate function to BitMap API
• ffd43c9: 8327461: KeyStore getEntry is not thread-safe
• 680ac2c: 8327689: RISC-V: adjust test filters of zfh extension
• 570ad67: 8269428: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out
• 63dd6d1: 8327387: G1: Refactor region liveness processing after completion of concurrent marking
• f2b5ffd: 8326578: Clean up networking properties documentation
• ... and 106 more: https://git.openjdk.org/jdk/compare/43af12039f13b884ab632ab403691530996e961c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[matias9927]

LGTM! Please don't forget to address Ioi's nit before integration, thanks.

[calvinccheung]

Thanks @iklam, @matias9927 for the reviews.

/integrate

[openjdk]

Going to push as commit 41450e9.
Since your change was applied there have been 116 commits pushed to the master branch:

• 0a6e64e: 8327424: ProblemList serviceability/sa/TestJmapCore.java on all platforms with ZGC
• c65d308: 8327812: JFR: Remove debug message in Function.Maximum
• b9bc31f: 8327790: Improve javadoc for ResolvedJavaType.hasFinalizableSubclass
• 18de932: 8325991: Accelerate Poly1305 on x86_64 using AVX2 instructions
• d74b907: 8327093: Add truncate function to BitMap API
• ffd43c9: 8327461: KeyStore getEntry is not thread-safe
• 680ac2c: 8327689: RISC-V: adjust test filters of zfh extension
• 570ad67: 8269428: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out
• 63dd6d1: 8327387: G1: Refactor region liveness processing after completion of concurrent marking
• f2b5ffd: 8326578: Clean up networking properties documentation
• ... and 106 more: https://git.openjdk.org/jdk/compare/43af12039f13b884ab632ab403691530996e961c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@calvinccheung Pushed as commit 41450e9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.