Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258455: problem list tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java #1796

Conversation

@stuart-marks
Copy link
Member

@stuart-marks stuart-marks commented Dec 16, 2020

Add to problem list to avoid tier1 CI failures.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258455: problem list tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1796/head:pull/1796
$ git checkout pull/1796

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 16, 2020

👋 Welcome back smarks! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Dec 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 16, 2020

@stuart-marks The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the compiler label Dec 16, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 16, 2020

Webrevs

Loading

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Looks good.

Thanks for fixing.

David

Loading

@stuart-marks stuart-marks changed the title 8258455: problem list tools/jdeprscan/tests/jdk/jdeprscan/TestRelease… 8258455: problem list tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java Dec 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 16, 2020

@stuart-marks This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258455: problem list tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java

Reviewed-by: dholmes, darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Dec 16, 2020
@stuart-marks
Copy link
Member Author

@stuart-marks stuart-marks commented Dec 16, 2020

/integrate

Loading

@openjdk openjdk bot closed this Dec 16, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 16, 2020

@stuart-marks Pushed as commit 47ba652.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants