8278527: java/util/concurrent/tck/JSR166TestCase.java fails nanoTime test

[jaikiran]

Can I get a review of this change which proposes to remove the SystemTest from among the JSR166TestCase?

As noted in https://bugs.openjdk.org/browse/JDK-8278527 the SystemTest.nanoTime test has been intermittently failing since a few years now. Martin and Paul have investigated this failure in the past and they note that this test is fragile and should be removed:

https://bugs.openjdk.org/browse/JDK-8278527?focusedId=14463658&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14463658

https://bugs.openjdk.org/browse/JDK-8278527?focusedId=14508958&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14508958

The commit in this PR removes the SystemTest that was enrolled into JSR166TestCase.

tier1 testing went fine with this change.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8278527: java/util/concurrent/tck/JSR166TestCase.java fails nanoTime test (Bug - P3)

Reviewers

• Martin Buchholz (@Martin-Buchholz - Reviewer)
• Lance Andersen (@LanceAndersen - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17960/head:pull/17960
$ git checkout pull/17960

Update a local copy of the PR:
$ git checkout pull/17960
$ git pull https://git.openjdk.org/jdk.git pull/17960/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17960

View PR using the GUI difftool:
$ git pr show -t 17960

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17960.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b67831ac)

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278527: java/util/concurrent/tck/JSR166TestCase.java fails nanoTime test

Reviewed-by: martin, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 9f9a732: 8325752: Remove badMetaWordVal
• 864cf22: 8325742: Remove MetaWord usage from MemRegion
• 8e5c0ee: 8324832: JFR: Improve sorting of 'jfr summary'
• 724a2a2: 8321192: j.a.PrintJob/ImageTest/ImageTest.java: Fail or skip the test if there's no printer
• f365d80: 8325153: SEGV in stackChunkOopDesc::derelativize_address(int)
• 4406915: 8323274: C2: array load may float above range check
• cc1e216: 8326461: tools/jlink/CheckExecutable.java fails as .debuginfo files are not executable
• 10eafdc: 8325870: Zap end padding bits for ArrayOops in non-release builds
• 0f4cd8f: 8326414: Serial: Inline SerialHeap::create_rem_set
• 8b30503: 8323695: RenderPerf (2D) enhancements (23.12)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jaikiran]

Thank you Martin and Lance for the reviews.

[jaikiran]

/integrate

[openjdk]

Going to push as commit 54f09d7.
Since your change was applied there have been 12 commits pushed to the master branch:

• 00ffc42: 8318761: MessageFormat pattern support for CompactNumberFormat, ListFormat, and DateTimeFormatter
• d695af8: 8326376: java -version failed with CONF=fastdebug -XX:InitialCodeCacheSize=1024K -XX:ReservedCodeCacheSize=1200k
• 9f9a732: 8325752: Remove badMetaWordVal
• 864cf22: 8325742: Remove MetaWord usage from MemRegion
• 8e5c0ee: 8324832: JFR: Improve sorting of 'jfr summary'
• 724a2a2: 8321192: j.a.PrintJob/ImageTest/ImageTest.java: Fail or skip the test if there's no printer
• f365d80: 8325153: SEGV in stackChunkOopDesc::derelativize_address(int)
• 4406915: 8323274: C2: array load may float above range check
• cc1e216: 8326461: tools/jlink/CheckExecutable.java fails as .debuginfo files are not executable
• 10eafdc: 8325870: Zap end padding bits for ArrayOops in non-release builds
• ... and 2 more: https://git.openjdk.org/jdk/compare/8e5f6ddb68572c0cc8b6e256e423706f6f7cec94...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit 54f09d7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.