-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234 #17967
Conversation
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
Webrevs
|
/label +build |
@magicus |
With the one exception above I agree with these choices going forward. I don't think it matters that exporting for the debugger is not actually necessary on some platforms, and so code simplicity wins out for me. That said the litmus test will be whether hermetic Java encounters any conflicts. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup!
216d0db
to
b6bd5f2
Compare
@magicus Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout hotspot-symbols-followup
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@magicus this pull request can not be integrated into git checkout hotspot-symbols-followup
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
There was a bit back and forth with this PR, but now I believe it is finally ready. Any reviewers? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me. Thanks.
@magicus This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit e6b3bda.
Your commit was automatically rebased without conflicts. |
Once JDK-8017234 has been integrated, it is possible to do some cleanup. The goal of JDK-8017234 was to not change any behavior, even if that behavior seemed odd.
Now let's try to fix that. We can:
a) remove JNIEXPORT from c2v functions.
b) make debug.cpp functions exported similarly on all platforms.
c) remove JNIEXPORT from aarch64 asm debug function.
Note that this PR is dependent on #17955.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17967/head:pull/17967
$ git checkout pull/17967
Update a local copy of the PR:
$ git checkout pull/17967
$ git pull https://git.openjdk.org/jdk.git pull/17967/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 17967
View PR using the GUI difftool:
$ git pr show -t 17967
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17967.diff
Webrev
Link to Webrev Comment