8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234

[magicus]

Once JDK-8017234 has been integrated, it is possible to do some cleanup. The goal of JDK-8017234 was to not change any behavior, even if that behavior seemed odd.

Now let's try to fix that. We can:

a) remove JNIEXPORT from c2v functions.
b) make debug.cpp functions exported similarly on all platforms.
c) remove JNIEXPORT from aarch64 asm debug function.

Note that this PR is dependent on #17955.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234 (Bug - P3)

Reviewers

• Daniel Jeliński (@djelinski - Reviewer)
• Julian Waters (@TheShermanTanker - Committer) ⚠️ Review applies to b6bd5f22
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17967/head:pull/17967
$ git checkout pull/17967

Update a local copy of the PR:
$ git checkout pull/17967
$ git pull https://git.openjdk.org/jdk.git pull/17967/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17967

View PR using the GUI difftool:
$ git pr show -t 17967

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17967.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into pr/17955 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@magicus The following labels will be automatically applied to this pull request:

• graal
• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (387d243b)
• 03: Full (43c3513b)
• 02: Full - Incremental (b6bd5f22)
• 01: Full - Incremental (216d0db5)
• 00: Full (18b3f1d6)

[magicus]

/label +build

[openjdk]

@magicus
The build label was successfully added.

[dholmes-ora]

With the one exception above I agree with these choices going forward. I don't think it matters that exporting for the debugger is not actually necessary on some platforms, and so code simplicity wins out for me. That said the litmus test will be whether hermetic Java encounters any conflicts.

Thanks

[djelinski]

Nice cleanup!

[openjdk]

@magicus Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout hotspot-symbols-followup
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@magicus this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout hotspot-symbols-followup
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[magicus]

There was a bit back and forth with this PR, but now I believe it is finally ready. Any reviewers?

[dholmes-ora]

Seems fine to me. Thanks.

[openjdk]

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234

Reviewed-by: djelinski, jwaters, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 4dd6c44: 8326529: JFR: Test for CompilerCompile events fails due to time out
• 33f2382: 8325807: Shenandoah: Refactor full gc in preparation for generational mode changes
• 419191c: 8325680: Uninitialised memory in deleteGSSCB of GSSLibStub.c:179
• 349df0a: 8326726: Problem list Exhaustiveness.java due to 8326616
• 552411f: 8326824: Test: remove redundant test in compiler/vectorapi/reshape/utils/TestCastMethods.java
• 9f0e7da: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop
• 81b065a: 8326714: Make file-local functions static in src/java.base/unix/native/libjava/childproc.c
• 4fcae1a: 8326722: Cleanup unnecessary forward declaration in collectedHeap.hpp
• c5c866a: 8326219: applications/kitchensink/Kitchensink8H.java timed out
• ac3ce2a: 8326583: Remove over-generalized DefineNativeToolchain solution

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[magicus]

/integrate

[openjdk]

Going to push as commit e6b3bda.
Since your change was applied there have been 14 commits pushed to the master branch:

• 1ab6bd4: 8326135: Enhance adlc to report unused operands
• 3b90ddf: 8326685: Linux builds not reproducible if two builds configured in different build folders
• 9b1f1e5: 8326389: [test] improve assertEquals failure output
• 6cad07c: 8325746: Refactor Loop Unswitching code
• 4dd6c44: 8326529: JFR: Test for CompilerCompile events fails due to time out
• 33f2382: 8325807: Shenandoah: Refactor full gc in preparation for generational mode changes
• 419191c: 8325680: Uninitialised memory in deleteGSSCB of GSSLibStub.c:179
• 349df0a: 8326726: Problem list Exhaustiveness.java due to 8326616
• 552411f: 8326824: Test: remove redundant test in compiler/vectorapi/reshape/utils/TestCastMethods.java
• 9f0e7da: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop
• ... and 4 more: https://git.openjdk.org/jdk/compare/bceaed6d4de391d1fdac0d35384c415a7c484d28...master

Your commit was automatically rebased without conflicts.

[openjdk]

@magicus Pushed as commit e6b3bda.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.