Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311002: missing @since info in 21 files in jdk.security.auth #17969

Closed
wants to merge 1 commit into from

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented Feb 22, 2024

Add @since info. JAAS was included in JDK 1.4 and these classes were all in the initial release.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8311002: missing @since info in 21 files in jdk.security.auth (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17969/head:pull/17969
$ git checkout pull/17969

Update a local copy of the PR:
$ git checkout pull/17969
$ git pull https://git.openjdk.org/jdk.git pull/17969/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17969

View PR using the GUI difftool:
$ git pr show -t 17969

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17969.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 22, 2024

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 22, 2024
@openjdk
Copy link

openjdk bot commented Feb 22, 2024

@wangweij The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Feb 22, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 22, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 5, 2024

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311002: missing @since info in 21 files in jdk.security.auth

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 139 new commits pushed to the master branch:

  • 809995b: 8174269: Remove COMPAT locale data provider from JDK
  • c6641c7: 8326831: Clarify test harness control variables in make help
  • 3d106cb: 8325139: JFR SwapSpace event - add free swap space information on Linux when running in a container environment
  • c00c939: 8327364: Parallel: Remove unused ParallelCompactData::add_obj
  • 98f0b86: 8319690: [AArch64] C2 compilation hits offset_ok_for_immed: assert "c2 compiler bug"
  • 2372aba: 8326172: Dubious claim on long[]/double[] alignment in MemorySegment javadoc
  • c653e67: 8327225: Revert DataInputStream.readUTF to static final
  • a089ed2: 8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations
  • 560cf59: 8327287: Remove unused FLSVerifyDictionary debug option
  • fec51d4: 8327130: Serial: Remove Generation::record_spaces_top
  • ... and 129 more: https://git.openjdk.org/jdk/compare/724a2a2c4a6020188b7907509cd48aa126b79b0f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 5, 2024
@wangweij
Copy link
Contributor Author

wangweij commented Mar 5, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 5, 2024

Going to push as commit a7280d1.
Since your change was applied there have been 140 commits pushed to the master branch:

  • 721bfee: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries
  • 809995b: 8174269: Remove COMPAT locale data provider from JDK
  • c6641c7: 8326831: Clarify test harness control variables in make help
  • 3d106cb: 8325139: JFR SwapSpace event - add free swap space information on Linux when running in a container environment
  • c00c939: 8327364: Parallel: Remove unused ParallelCompactData::add_obj
  • 98f0b86: 8319690: [AArch64] C2 compilation hits offset_ok_for_immed: assert "c2 compiler bug"
  • 2372aba: 8326172: Dubious claim on long[]/double[] alignment in MemorySegment javadoc
  • c653e67: 8327225: Revert DataInputStream.readUTF to static final
  • a089ed2: 8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations
  • 560cf59: 8327287: Remove unused FLSVerifyDictionary debug option
  • ... and 130 more: https://git.openjdk.org/jdk/compare/724a2a2c4a6020188b7907509cd48aa126b79b0f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 5, 2024
@openjdk openjdk bot closed this Mar 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 5, 2024
@openjdk
Copy link

openjdk bot commented Mar 5, 2024

@wangweij Pushed as commit a7280d1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wangweij wangweij deleted the 8311002 branch March 5, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants