8310513: [s390x] Intrinsify recursive ObjectMonitor locking

[offamitkumar]

s390 implementation of JDK-8277180. PPC implementation for the same: #7305

I had tested tier1 on fastdebug, release vm.

BenchMarking:

./build/linux-s390x-server-release/jdk/bin/java -Xms4g -Xmx4g -jar dacapo-9.12-MR1-bach.jar h2 -s huge -t 1 -n 1

without patch: 
===== DaCapo 9.12-MR1 h2 PASSED in 223023 msec =====
===== DaCapo 9.12-MR1 h2 PASSED in 225686 msec =====
===== DaCapo 9.12-MR1 h2 PASSED in 219824 msec =====
===== DaCapo 9.12-MR1 h2 PASSED in 226719 msec =====



with patch: 
===== DaCapo 9.12-MR1 h2 PASSED in 167816 msec =====
===== DaCapo 9.12-MR1 h2 PASSED in 174368 msec =====
===== DaCapo 9.12-MR1 h2 PASSED in 170517 msec =====
===== DaCapo 9.12-MR1 h2 PASSED in 169349 msec =====

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8310513: [s390x] Intrinsify recursive ObjectMonitor locking (Enhancement - P4)

Reviewers

• Lutz Schmidt (@RealLucy - Reviewer) ⚠️ Review applies to 9f48baa9
• Martin Doerr (@TheRealMDoerr - Reviewer) ⚠️ Review applies to 9f48baa9

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17975/head:pull/17975
$ git checkout pull/17975

Update a local copy of the PR:
$ git checkout pull/17975
$ git pull https://git.openjdk.org/jdk.git pull/17975/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17975

View PR using the GUI difftool:
$ git pr show -t 17975

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17975.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@offamitkumar The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310513: [s390x] Intrinsify recursive ObjectMonitor locking

Reviewed-by: lucy, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 673 new commits pushed to the master branch:

• 635cb3c: 8329745: Update the documentation of ServerSocket and Socket to refer to StandardSocketOptions instead of legacy SocketOptions
• 5c9f036: 8329858: G1: Make G1VerifyLiveAndRemSetClosure stateless
• 492b954: 8329750: Change Universe functions to return more specific Klass* types
• 87131fb: 8329629: GC interfaces should work directly against nmethod instead of CodeBlob
• 5ea21c3: 8329878: Reduce public interface of CardTableBarrierSet
• a48289a: 8329761: Remove unused KeyBuilder and unusedSets from StyleContext
• 8907eda: 8325485: IncrementInstructions.of(int, int) is not storing the args
• b9331cd: 8329823: RISC-V: Need to sync CPU features with related JVM flags
• 71c5bbc: 8329527: Opcode.IFNONNULL.primaryTypeKind() is not ReferenceType
• 58e39c1: 8329884: Serial: Fix build failure due to ‘Copy’ has not been declared
• ... and 663 more: https://git.openjdk.org/jdk/compare/69a11c7f7ea7c4195a8ee56391bdf04c75bd8156...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 02: Full - Incremental (af3334e6)
• 01: Full - Incremental (9f48baa9)
• 00: Full (13f41304)

[RealLucy]

Looks good overall.
My change requests have the intention to make identical actions look identical. That helps with understanding the code.

[RealLucy]

LGTM.
Reviewed, provided GHA find no errors.

[offamitkumar]

Thanks @RealLucy !!!

@TheRealMDoerr would you please review this as well?

[TheRealMDoerr]

I couldn't spot any bugs.

[offamitkumar]

Thanks @TheRealMDoerr and @RealLucy for Review.

I ran the test again with -XX:-TieredCompilation flag and do not see any new failure there as well.

/integrate

[openjdk]

Going to push as commit 47df145.
Since your change was applied there have been 688 commits pushed to the master branch:

• b81b86d: 8329729: java/util/Properties/StoreReproducibilityTest.java times out
• 6276789: 8328785: IOException: Symbol not found: C_GetInterface for PKCS11 interface prior to V3.0
• 316361b: 8328318: Wrong description in X509Extension.getExtensionValue method javadoc
• b80ba08: 8329967: Build failure after JDK-8329628
• 4bba445: 8325659: Normalize Random usage by incubator vector tests
• 6736792: 8329628: Additional changes after JDK-8329332
• 1e02a13: 8328614: hsdis: dlsym can't find decode symbol
• 23d161d: 8328630: Add logging when needed symbols in dll are missing.
• 2e925f2: 8329726: Use non-short forward jumps in lightweight locking
• e75e1cb: 8329955: Class-File API ClassPrinter does not print bootstrap methods arguments
• ... and 678 more: https://git.openjdk.org/jdk/compare/69a11c7f7ea7c4195a8ee56391bdf04c75bd8156...master

Your commit was automatically rebased without conflicts.

[openjdk]

@offamitkumar Pushed as commit 47df145.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.