Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8258469: Cleanup remaining safefetch test coding #1799

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Dec 16, 2020

JDK-8257828 fixed SafeFetch for non-java-thread situations on all platforms. It also introduced gtests.
JDK-8185734 fixed the problem that gtests were running without SEH catcher on Windows, preventing us from testing Windows x86 at least.

Since we have now gtests to test SafeFetch, and since all these issues are fixed, we can remove the related test coding in stubRoutines.cpp.

Testing: manual gtests and GH actions (the Linux x86 error can be ignored, see https://bugs.openjdk.java.net/browse/JDK-8258481).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1799/head:pull/1799
$ git checkout pull/1799

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2020

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 16, 2020

@tstuefe The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Dec 16, 2020
@tstuefe tstuefe marked this pull request as ready for review December 16, 2020 10:07
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 16, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 16, 2020

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!

@openjdk
Copy link

openjdk bot commented Dec 17, 2020

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258469: Cleanup remaining safefetch test coding

Reviewed-by: coleenp, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

  • 3f77a60: 8258582: HttpClient: the HttpClient doesn't explicitly shutdown its default executor when stopping.
  • f15528e: Merge
  • 30ca0a5: 8247994: Localize javadoc search
  • 47c180d: 8258515: javac should issue an error if an annotation is nested in a local class or interface
  • cb5a6b1: 8258225: compiler/c2/cr6340864/TestIntVect.java runs faster in interpreter
  • 61cbf0f: 8258293: tools/jpackage/share/RuntimePackageTest.java#id0 with RuntimePackageTest.testUsrInstallDir2
  • 7aac4dc: 8257621: JFR StringPool misses cached items across consecutive recordings
  • 61390d8: 8257999: Parallel GC crash in gc/parallel/TestDynShrinkHeap.java: new region is not in covered_region
  • 952dc70: 8257636: Update usage of "type" terminology in java.lang.Class and java.lang.reflect
  • 04a1e5b: 8258505: [TESTBUG] TestDivZeroWithSplitIf.java fails due to missing UnlockDiagnosticVMOptions
  • ... and 42 more: https://git.openjdk.java.net/jdk/compare/cdb53422e8f57aeee82eb535b1dc77b62c9b9783...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 17, 2020
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks,
David

@tstuefe
Copy link
Member Author

tstuefe commented Dec 18, 2020

Thanks Coleen and David!
/integrate

@openjdk openjdk bot closed this Dec 18, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 18, 2020
@openjdk
Copy link

openjdk bot commented Dec 18, 2020

@tstuefe Since your change was applied there have been 53 commits pushed to the master branch:

  • 1e03ca1: 8258471: "search codecache" clhsdb command does not work
  • 3f77a60: 8258582: HttpClient: the HttpClient doesn't explicitly shutdown its default executor when stopping.
  • f15528e: Merge
  • 30ca0a5: 8247994: Localize javadoc search
  • 47c180d: 8258515: javac should issue an error if an annotation is nested in a local class or interface
  • cb5a6b1: 8258225: compiler/c2/cr6340864/TestIntVect.java runs faster in interpreter
  • 61cbf0f: 8258293: tools/jpackage/share/RuntimePackageTest.java#id0 with RuntimePackageTest.testUsrInstallDir2
  • 7aac4dc: 8257621: JFR StringPool misses cached items across consecutive recordings
  • 61390d8: 8257999: Parallel GC crash in gc/parallel/TestDynShrinkHeap.java: new region is not in covered_region
  • 952dc70: 8257636: Update usage of "type" terminology in java.lang.Class and java.lang.reflect
  • ... and 43 more: https://git.openjdk.java.net/jdk/compare/cdb53422e8f57aeee82eb535b1dc77b62c9b9783...master

Your commit was automatically rebased without conflicts.

Pushed as commit 853c047.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tstuefe tstuefe deleted the JDK-8258469-remove-safefetch-test-coding branch January 15, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants