8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used

[RealCLanger]

The new test JmodExcludedFiles.java checks that no debug symbol files are contained in the jmod files. It does not take into account that with configure option --with-external-symbols-in-bundles=public we want to have stripped pdb files, also in jmods, to get native callstacks with line number.

This modifies the test and checks if equivalent *stripped.pdb files exist when .pdb files are encountered inside jmods. In that case one can assume that --with-external-symbols-in-bundles=public was chosen as configure option.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used (Bug - P4)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17990/head:pull/17990
$ git checkout pull/17990

Update a local copy of the PR:
$ git checkout pull/17990
$ git pull https://git.openjdk.org/jdk.git pull/17990/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17990

View PR using the GUI difftool:
$ git pr show -t 17990

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17990.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealCLanger The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (26d8842e)

[RealCLanger]

@mlchung, mind to have a look here? Thanks 😄

[MBaesken]

Looks okay to me, but could we print here RuntimeException(jmodFile + " is expected not to include native debug symbols not only the jmod but also the unwanted file(s) ?

[RealCLanger]

Looks okay to me, but could we print here RuntimeException(jmodFile + " is expected not to include native debug symbols not only the jmod but also the unwanted file(s) ?

This information is already printed in isNativeDebugSymbol. So in case of failure, you'll find the culprit in the test output.

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 78 new commits pushed to the master branch:

• a065eba: 8326496: [test] checkHsErrFileContent support printing hserr in error case
• 0899b3b: 8326612: Parallel: remove redundant assertion from ScavengeRootsTask
• 12404a5: 8324790: ifnode::fold_compares_helper cleanup
• 0d35450: 8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14
• 8d6f784: 8327056: Remove unused static char array in JvmtiAgentList::lookup
• 43af120: 8326959: Improve JVMCI option help
• 742c776: 8322743: C2: prevent lock region elimination in OSR compilation
• d29cefb: 8326838: JFR: Native mirror events
• b8fc418: 8326525: com/sun/tools/attach/BasicTests.java does not verify AgentLoadException case
• d9aa1de: 8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests
• ... and 68 more: https://git.openjdk.org/jdk/compare/c26c5833ccd7bdfd3f8ed9da76334d5b4e6e55ca...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealCLanger]

Thanks for the review, Matthias.

/integrate

[openjdk]

Going to push as commit 43c6f0b.
Since your change was applied there have been 102 commits pushed to the master branch:

• b5cd7ef: 8319901: Recursive lightweight locking: ppc64le implementation
• 0583f73: 8323183: ClassFile API performance improvements
• b69d1b5: 8327042: G1: Parallelism used for redirty logged cards needs better control.
• e889b46: 8327071: [Testbug] g-tests for cgroup leave files in /tmp on linux
• 7c71f18: 8324829: Uniform use of synchronizations in NMT
• 97dc0ed: 8327171: Fix more NULL usage backsliding
• f3b15ab: 8327059: os::Linux::print_proc_sys_info add swappiness information
• 31ac871: 8326692: JVMCI Local.endBci is off-by-one
• 37e01ef: 8326586: Improve Speed of System.map
• a3d51d2: 8326915: NPE when a validating parser is restricted
• ... and 92 more: https://git.openjdk.org/jdk/compare/c26c5833ccd7bdfd3f8ed9da76334d5b4e6e55ca...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger Pushed as commit 43c6f0b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.