8326612: Parallel: remove redundant assertion from ScavengeRootsTask

[reinrich]

This change removes a redundant assertion from ScavengeRootsTask.
The assertion is redundant because _old_gen is initialized to old_gen at L296 which is dereferenced at L297 before the assertion is reached.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8326612: Parallel: remove redundant assertion from ScavengeRootsTask (Enhancement - P4)

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Albert Mingkun Yang (@albertnetymk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17994/head:pull/17994
$ git checkout pull/17994

Update a local copy of the PR:
$ git checkout pull/17994
$ git pull https://git.openjdk.org/jdk.git pull/17994/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17994

View PR using the GUI difftool:
$ git pr show -t 17994

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17994.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@reinrich The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[tschatzl]

Since old_gen is already dereferenced in the initializer list, the code would already crash before reaching this assert anyway, so it is useless.

[tschatzl]

You do need to file a CR and fix the title though until this can be moved along.

[openjdk]

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326612: Parallel: remove redundant assertion from ScavengeRootsTask

Reviewed-by: tschatzl, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 61 new commits pushed to the master branch:

• e772e78: 8326948: Force English locale for timeout formatting
• d9ef16d: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns
• 998d0ba: 8324799: Use correct extension for C++ test headers
• 0735c8a: 8318302: ThreadCountLimit.java failed with "Native memory allocation (mprotect) failed to protect 16384 bytes for memory to guard stack pages"
• 5fa2bdc: 8326953: Race in creation of win-exports.def with static-libs
• be2b92b: 8326694: Defer setting of autocapitalize attribute
• 38ad514: 8326687: Inconsistent use of "ZIP", "Zip" and "zip" in java.util.zip/jar zipfs javadoc
• b938a5c: 8324969: C2: prevent elimination of unbalanced coarsened locking regions
• a93605f: 8326763: Consolidate print methods in ContiguousSpace
• 41242cb: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java
• ... and 51 more: https://git.openjdk.org/jdk/compare/d10f277bd39bb5ac9bd48939c916de607fef8ace...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[reinrich]

You do need to file a CR and fix the title though until this can be moved along.

Thanks Thomas! I've done that now.
(was sick the last days)

[mlbridge]

Webrevs

• 00: Full (dfc3d5bb)

[reinrich]

Thanks for the reviews.
/integrate

[openjdk]

Going to push as commit 0899b3b.
Since your change was applied there have been 73 commits pushed to the master branch:

• 12404a5: 8324790: ifnode::fold_compares_helper cleanup
• 0d35450: 8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14
• 8d6f784: 8327056: Remove unused static char array in JvmtiAgentList::lookup
• 43af120: 8326959: Improve JVMCI option help
• 742c776: 8322743: C2: prevent lock region elimination in OSR compilation
• d29cefb: 8326838: JFR: Native mirror events
• b8fc418: 8326525: com/sun/tools/attach/BasicTests.java does not verify AgentLoadException case
• d9aa1de: 8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests
• bbfda65: 8326897: (fs) The utility TestUtil.supportsLinks is wrongly used to check for hard link support
• db0e2b8: 8326944: (ch) Minor typo in the ScatteringByteChannel.read(ByteBuffer[] dsts,int offset,int length) javadoc
• ... and 63 more: https://git.openjdk.org/jdk/compare/d10f277bd39bb5ac9bd48939c916de607fef8ace...master

Your commit was automatically rebased without conflicts.

[openjdk]

@reinrich Pushed as commit 0899b3b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.