Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325361: Make sun.net.www.MessageHeader final #17997

Closed
wants to merge 2 commits into from

Conversation

Korov
Copy link
Contributor

@Korov Korov commented Feb 25, 2024

Make sun.net.www.MessageHeader final, and replace C-style array type declaration with Java-style array declaration.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8325361: Make sun.net.www.MessageHeader final (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17997/head:pull/17997
$ git checkout pull/17997

Update a local copy of the PR:
$ git checkout pull/17997
$ git pull https://git.openjdk.org/jdk.git pull/17997/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17997

View PR using the GUI difftool:
$ git pr show -t 17997

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17997.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 25, 2024

👋 Welcome back Korov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 25, 2024
@openjdk
Copy link

openjdk bot commented Feb 25, 2024

@Korov The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Feb 25, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 25, 2024

Webrevs

@AlanBateman
Copy link
Contributor

The motivation for JDK-8325361 is to remove @SuppressWarnings("this-escape") from the constructor.

@Korov Korov closed this Feb 25, 2024
@Korov Korov reopened this Feb 25, 2024
@Korov
Copy link
Contributor Author

Korov commented Feb 25, 2024

The motivation for JDK-8325361 is to remove @SuppressWarnings("this-escape") from the constructor.

Hi @AlanBateman ,Thanks for reminding me, I'm new to this project, It would be much appreciated if you could provide any constructive criticism and feedback.

@Korov Korov closed this Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
net net-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants