Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8326590: Improve description of MarkStackSize[Max] flags #18003

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Feb 26, 2024

Hi all,

please review this changes to the description of MarkStackSize[Max] to add the unit of the given value.

Testing: local compilation

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8326590: Improve description of MarkStackSize[Max] flags (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18003/head:pull/18003
$ git checkout pull/18003

Update a local copy of the PR:
$ git checkout pull/18003
$ git pull https://git.openjdk.org/jdk.git pull/18003/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18003

View PR using the GUI difftool:
$ git pr show -t 18003

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18003.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 26, 2024

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8326590 8326590: Improve description of MarkStackSize[Max] flags Feb 26, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 26, 2024
@openjdk
Copy link

openjdk bot commented Feb 26, 2024

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Feb 26, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 26, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 26, 2024

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326590: Improve description of MarkStackSize[Max] flags

Reviewed-by: iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 26, 2024
@walulyai
Copy link
Member

Looks Trivial

@tschatzl
Copy link
Contributor Author

Thanks @walulyai for your review.

/integrate

@openjdk
Copy link

openjdk bot commented Feb 28, 2024

Going to push as commit eb4b6fa.
Since your change was applied there have been 84 commits pushed to the master branch:

  • e7e8083: 8326781: G1ConcurrentMark::top_at_rebuild_start() should take a HeapRegion* not an uint
  • e6b3bda: 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234
  • 1ab6bd4: 8326135: Enhance adlc to report unused operands
  • 3b90ddf: 8326685: Linux builds not reproducible if two builds configured in different build folders
  • 9b1f1e5: 8326389: [test] improve assertEquals failure output
  • 6cad07c: 8325746: Refactor Loop Unswitching code
  • 4dd6c44: 8326529: JFR: Test for CompilerCompile events fails due to time out
  • 33f2382: 8325807: Shenandoah: Refactor full gc in preparation for generational mode changes
  • 419191c: 8325680: Uninitialised memory in deleteGSSCB of GSSLibStub.c:179
  • 349df0a: 8326726: Problem list Exhaustiveness.java due to 8326616
  • ... and 74 more: https://git.openjdk.org/jdk/compare/921507c51062e82e55ade43262e7eb8036ea4bd6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 28, 2024
@openjdk openjdk bot closed this Feb 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 28, 2024
@openjdk
Copy link

openjdk bot commented Feb 28, 2024

@tschatzl Pushed as commit eb4b6fa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8326590-markstacksize-desscription branch June 11, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants