-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8326590: Improve description of MarkStackSize[Max] flags #18003
8326590: Improve description of MarkStackSize[Max] flags #18003
Conversation
👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into |
@tschatzl This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 40 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Looks Trivial |
Thanks @walulyai for your review. /integrate |
Going to push as commit eb4b6fa.
Your commit was automatically rebased without conflicts. |
Hi all,
please review this changes to the description of
MarkStackSize[Max]
to add the unit of the given value.Testing: local compilation
Thanks,
Thomas
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18003/head:pull/18003
$ git checkout pull/18003
Update a local copy of the PR:
$ git checkout pull/18003
$ git pull https://git.openjdk.org/jdk.git pull/18003/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18003
View PR using the GUI difftool:
$ git pr show -t 18003
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18003.diff
Webrev
Link to Webrev Comment