8326529: JFR: Test for CompilerCompile events fails due to time out

[roberttoyonaga]

The test jdk\jfr\event\compiler\TestCompilerCompile.java times-out waiting for the compilation of the test methods.

#-----testresult-----
description=file\:/C\:/cygwin64/home/rtoyonag/jdk8u/jdk/test/jdk/jfr/event/compiler/TestCompilerCompile.java
elapsed=121659 0\:02\:01.659
end=Thu Feb 22 18\:52\:04 UTC 2024
environment=regtest
execStatus=Error. Program `C\:\\cygwin64\\home\\rtoyonag\\jdk8u\\build\\windows-x86-normal-server-release\\images\\j2sdk-image\\bin\\java' timed out (timeout set to 120000ms, elapsed time including timeout handling was 120404ms).
harnessLoaderMode=Classpath Loader
harnessVariety=Full Bundle
hostname=TEST-WIN2016-1.2nnkwmsaofoerpj2hhoaq1ahee.bx.internal.cloudapp.net
javatestOS=Windows Server 2016 10.0 (amd64)
javatestVersion=6.0-ea+b24-2024-02-01-${BUILT_FROM_COMMIT}
jtregVersion=jtreg 7.3.1 dev 0
script=com.sun.javatest.regtest.exec.RegressionScript
sections=script_messages build build main build main
start=Thu Feb 22 18\:50\:02 UTC 2024
test=jdk/jfr/event/compiler/TestCompilerCompile.java
testJDK=C\:\\cygwin64\\home\\rtoyonag\\jdk8u\\build\\windows-x86-normal-server-release\\images\\j2sdk-image
testJDK_OS=[name\:Windows Server 2016,arch\:x86,version\:10.0,family\:windows,simple_arch\:i586,simple_version\:10.0,processors\:2,maxMemory\:8589463552,maxSwap\:13622628352]
testJDK_os.arch=x86
testJDK_os.name=Windows Server 2016
testJDK_os.version=10.0
totalTime=121662
user.name=rtoyonag
work=C\:\\cygwin64\\home\\rtoyonag\\jdk8u\\JTwork\\jdk\\jfr\\event\\compiler
...
Timeout signalled after 120 seconds
result: Error. Program `C:\cygwin64\home\rtoyonag\jdk8u\build\windows-x86-normal-server-release\images\j2sdk-image\bin\java' timed out (timeout set to 120000ms, elapsed time including timeout handling was 120404ms).

This PR limits compilation only to the test methods we care about (similar to what jdk\jfr\event\compiler\TestCompilerPhases.java does).

This problem is seen in Adoptium automated tests for windows 32 bit. I've only been able to reproduce the issue with JDK8, but the test code has not changed since JDK8 so I think it makes sense to make the change here and backport it. Although I haven't seen the problem in later JDK versions, it shouldn't hurt to limit compilation to the specific test methods we care about.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8326529: JFR: Test for CompilerCompile events fails due to time out (Bug - P4)

Reviewers

• Erik Gahlin (@egahlin - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18010/head:pull/18010
$ git checkout pull/18010

Update a local copy of the PR:
$ git checkout pull/18010
$ git pull https://git.openjdk.org/jdk.git pull/18010/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18010

View PR using the GUI difftool:
$ git pr show -t 18010

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18010.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back roberttoyonaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@roberttoyonaga The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b3d93fda)

[egahlin]

Thanks for fixing. I can sponsor change.

[openjdk]

@roberttoyonaga This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326529: JFR: Test for CompilerCompile events fails due to time out

Reviewed-by: egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

• c5c866a: 8326219: applications/kitchensink/Kitchensink8H.java timed out
• ac3ce2a: 8326583: Remove over-generalized DefineNativeToolchain solution
• bceaed6: 8326406: Remove mapfile support from makefiles
• 16d917a: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump
• 60cbf29: 8325754: Dead AbstractQueuedSynchronizer$ConditionNodes survive minor garbage collections
• da14aa4: 8017234: Hotspot should stop using mapfiles
• d482c1a: 8326524: Rename agent_common.h
• e85355a: 8320005: Allow loading of shared objects with .a extension on AIX
• 5d3d40d: 8326659: Serial: Remove redundant TenuredSpace::print_on
• 7583419: 8324828: Avoid multiple search of reserved regions during splitting
• ... and 19 more: https://git.openjdk.org/jdk/compare/bb6b04897b5d83dd89fc11074dd66af024f9c6fc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@egahlin) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[roberttoyonaga]

/integrate

[openjdk]

@roberttoyonaga
Your change (at version b3d93fd) is now ready to be sponsored by a Committer.

[egahlin]

/sponsor

[openjdk]

Going to push as commit 4dd6c44.
Since your change was applied there have been 36 commits pushed to the master branch:

• 33f2382: 8325807: Shenandoah: Refactor full gc in preparation for generational mode changes
• 419191c: 8325680: Uninitialised memory in deleteGSSCB of GSSLibStub.c:179
• 349df0a: 8326726: Problem list Exhaustiveness.java due to 8326616
• 552411f: 8326824: Test: remove redundant test in compiler/vectorapi/reshape/utils/TestCastMethods.java
• 9f0e7da: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop
• 81b065a: 8326714: Make file-local functions static in src/java.base/unix/native/libjava/childproc.c
• 4fcae1a: 8326722: Cleanup unnecessary forward declaration in collectedHeap.hpp
• c5c866a: 8326219: applications/kitchensink/Kitchensink8H.java timed out
• ac3ce2a: 8326583: Remove over-generalized DefineNativeToolchain solution
• bceaed6: 8326406: Remove mapfile support from makefiles
• ... and 26 more: https://git.openjdk.org/jdk/compare/bb6b04897b5d83dd89fc11074dd66af024f9c6fc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin @roberttoyonaga Pushed as commit 4dd6c44.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.