-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8198237: [macos] Test java/awt/Frame/ExceptionOnSetExtendedStateTest/ExceptionOnSetExtendedStateTest.java fails #18014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back achung! A progress list of the required criteria for merging this PR into |
|
@alisenchung To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
lgxbslgx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
If you want to solve this bug in older JDK version, it is good to file another issue to match this PR. If not, you should change the fix version of this issue.
@alisenchung I think changing the fix version of the bug is probably the best approach. A backport could be done for earlier versions, if desired. I don't think we want to use a different bug ID either for the mainline or for prior releases because this bug ID is referenced in the problem list. |
|
I've changed the fix version to 23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Is it known when the test stopped failing? Any fix that resolved the failure?
|
@alisenchung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 597 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
I'm not sure, but the last failure was seen on JDK11, so the failure is quite old |
|
/integrate |
|
Going to push as commit 862e615.
Your commit was automatically rebased without conflicts. |
|
@alisenchung Pushed as commit 862e615. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
De-problem listing test. Test does not fail on mainline on macos13 or 14
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18014/head:pull/18014$ git checkout pull/18014Update a local copy of the PR:
$ git checkout pull/18014$ git pull https://git.openjdk.org/jdk.git pull/18014/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18014View PR using the GUI difftool:
$ git pr show -t 18014Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18014.diff