JDK-8258479: Minor cleanups in VMError

[tstuefe]

A list of smaller cleanups, each one too small to justify an own issue:

1. VMError exposes is_error_reported(), fatal_error_in_progress() and get_first_error_tid(). These functions are used from outside to check on the state of error handling. They can be combined and duplicate coding removed. Also, VMError::_error_reported can be removed, since its redundant with VMError::_first_error_tid != -1)
2. A lot of methods are unnecessarily public
3. the env_var array in vmError.cpp can be limited to file scope
4. definition of VMError static members should be combined to the start of the cpp file
5. the comment describing VMError::report() is misplaced
6. VMError::reset_signal_handlers() is badly named; nothing is reset here, the secondary signal handler is installed.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8258479: Minor cleanups in VMError

Reviewers

• Lois Foltan (@lfoltan - Reviewer) ⚠️ Review applies to 47c59b5
• Coleen Phillimore (@coleenp - Reviewer) ⚠️ Review applies to 47c59b5

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1802/head:pull/1802
$ git checkout pull/1802

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (b286e94)
• 01: Full - Incremental (47c59b5)
• 00: Full (47edef8)

[lfoltan]

Nice cleanup! A couple of files need copyright updated.
Lois

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258479: Minor cleanups in VMError

Reviewed-by: lfoltan, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

• c11525a: 8257772: Vectorizing clear memory operation using AVX-512 masked operations
• d77b49d: 8258233: Reenable another fixed problemlisted test
• 513269d: 8196093: javax/swing/JComboBox/8072767/bug8072767.java fails
• 643ddc1: 8257882: Implement linkToNative intrinsic on AArch64
• 11bd7a8: Merge
• ce0ab2d: 8258338: Support deprecated records
• 6b4b676: 8241353: NPE in ToolProvider.getSystemJavaCompiler
• 87644a2: 8255880: UI of Swing components is not redrawn after their internal state changed
• 72dfba8: 8257637: Update usage of "type" terminology in java.lang.annotation
• b5a3a5b: 8258236: Segfault in ClassListParser::resolve_indy dumping static AppCDS archive
• ... and 20 more: https://git.openjdk.java.net/jdk/compare/cdb53422e8f57aeee82eb535b1dc77b62c9b9783...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tstuefe]

Nice cleanup! A couple of files need copyright updated.
Lois

Thank you Lois! I'll fix the copyrights before integrating.

[coleenp]

Looks good! Thank you for this cleanup.

[tstuefe]

Looks good! Thank you for this cleanup.

:) Thanks Coleen!

[tstuefe]

/integrate

[openjdk]

@tstuefe Since your change was applied there have been 30 commits pushed to the master branch:

• c11525a: 8257772: Vectorizing clear memory operation using AVX-512 masked operations
• d77b49d: 8258233: Reenable another fixed problemlisted test
• 513269d: 8196093: javax/swing/JComboBox/8072767/bug8072767.java fails
• 643ddc1: 8257882: Implement linkToNative intrinsic on AArch64
• 11bd7a8: Merge
• ce0ab2d: 8258338: Support deprecated records
• 6b4b676: 8241353: NPE in ToolProvider.getSystemJavaCompiler
• 87644a2: 8255880: UI of Swing components is not redrawn after their internal state changed
• 72dfba8: 8257637: Update usage of "type" terminology in java.lang.annotation
• b5a3a5b: 8258236: Segfault in ClassListParser::resolve_indy dumping static AppCDS archive
• ... and 20 more: https://git.openjdk.java.net/jdk/compare/cdb53422e8f57aeee82eb535b1dc77b62c9b9783...master

Your commit was automatically rebased without conflicts.

Pushed as commit 178c001.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.