8326763: Consolidate print methods in ContiguousSpace #18022

albertnetymk · 2024-02-27T09:46:50Z

Trivial inlining and removing some unused methods.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8326763: Consolidate print methods in ContiguousSpace (Enhancement - P4)

Reviewers

Stefan Karlsson (@stefank - Reviewer)
Guoxiong Li (@lgxbslgx - Committer) ⚠️ Review applies to 5f8f543e

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18022/head:pull/18022
$ git checkout pull/18022

Update a local copy of the PR:
$ git checkout pull/18022
$ git pull https://git.openjdk.org/jdk.git pull/18022/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18022

View PR using the GUI difftool:
$ git pr show -t 18022

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18022.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-02-27T09:47:43Z

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-02-27T09:49:24Z

@albertnetymk The following label will be automatically applied to this pull request:

hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-02-27T09:52:01Z

Webrevs

stefank · 2024-02-27T09:58:54Z

src/hotspot/share/gc/shared/space.cpp

-              (int) ((double) used() * 100 / capacity()));
-}
-
-void ContiguousSpace::print() const { print_on(tty); }


It is a common pattern in HotSpot to have a print() function that delegates to print_on(tty). I think this function should be kept.

lgxbslgx

Looks good.

lgxbslgx · 2024-02-28T15:00:47Z

src/hotspot/share/gc/shared/space.cpp

-  print_short_on(st);
-  st->print_cr(" [" PTR_FORMAT ", " PTR_FORMAT ", " PTR_FORMAT ")",
-                p2i(bottom()), p2i(top()), p2i(end()));
+  st->print_cr(" space %zuK, %3d%% used [" PTR_FORMAT ", " PTR_FORMAT ", " PTR_FORMAT ")",


Why not use the previous SIZE_FORMAT?

%zu is shorter and easier to read, and it's widely used in new code; SIZE_FORMAT is used in old code when we didn't have %zu.

Got it. Thanks for your explanation.

openjdk · 2024-02-28T15:05:59Z

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326763: Consolidate print methods in ContiguousSpace

Reviewed-by: stefank, gli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

41242cb: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java
5db50ac: 8326892: Remove unused PSAdaptiveSizePolicyResizeVirtualSpaceAlot develop flag
eb4b6fa: 8326590: Improve description of MarkStackSize[Max] flags
e7e8083: 8326781: G1ConcurrentMark::top_at_rebuild_start() should take a HeapRegion* not an uint
e6b3bda: 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234
1ab6bd4: 8326135: Enhance adlc to report unused operands
3b90ddf: 8326685: Linux builds not reproducible if two builds configured in different build folders
9b1f1e5: 8326389: [test] improve assertEquals failure output
6cad07c: 8325746: Refactor Loop Unswitching code
4dd6c44: 8326529: JFR: Test for CompilerCompile events fails due to time out
... and 15 more: https://git.openjdk.org/jdk/compare/5d3d40d962ece0395d1da233e1f8db3de826cb93...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

albertnetymk · 2024-02-28T15:14:12Z

Thanks for review.

/integrate

openjdk · 2024-02-28T15:14:44Z

Going to push as commit a93605f.
Since your change was applied there have been 25 commits pushed to the master branch:

41242cb: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java
5db50ac: 8326892: Remove unused PSAdaptiveSizePolicyResizeVirtualSpaceAlot develop flag
eb4b6fa: 8326590: Improve description of MarkStackSize[Max] flags
e7e8083: 8326781: G1ConcurrentMark::top_at_rebuild_start() should take a HeapRegion* not an uint
e6b3bda: 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234
1ab6bd4: 8326135: Enhance adlc to report unused operands
3b90ddf: 8326685: Linux builds not reproducible if two builds configured in different build folders
9b1f1e5: 8326389: [test] improve assertEquals failure output
6cad07c: 8325746: Refactor Loop Unswitching code
4dd6c44: 8326529: JFR: Test for CompilerCompile events fails due to time out
... and 15 more: https://git.openjdk.org/jdk/compare/5d3d40d962ece0395d1da233e1f8db3de826cb93...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-02-28T15:14:50Z

@albertnetymk Pushed as commit a93605f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

trivial

7dd2cb5

openjdk bot changed the title ~~8326763~~ 8326763: Consolidate print methods in ContiguousSpace Feb 27, 2024

openjdk bot added the rfr Pull request is ready for review label Feb 27, 2024

openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Feb 27, 2024

stefank suggested changes Feb 27, 2024

View reviewed changes

review

5f8f543

lgxbslgx approved these changes Feb 28, 2024

View reviewed changes

review

f0fd027

lgxbslgx reviewed Feb 28, 2024

View reviewed changes

stefank approved these changes Feb 28, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Feb 28, 2024

openjdk bot added the integrated Pull request has been integrated label Feb 28, 2024

openjdk bot closed this Feb 28, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 28, 2024

albertnetymk deleted the trivial branch February 28, 2024 15:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8326763: Consolidate print methods in ContiguousSpace #18022

8326763: Consolidate print methods in ContiguousSpace #18022

albertnetymk commented Feb 27, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Feb 27, 2024

openjdk bot commented Feb 27, 2024

mlbridge bot commented Feb 27, 2024 •

edited

Loading

stefank Feb 27, 2024

lgxbslgx left a comment

lgxbslgx Feb 28, 2024

albertnetymk Feb 28, 2024

lgxbslgx Feb 28, 2024

openjdk bot commented Feb 28, 2024

albertnetymk commented Feb 28, 2024

openjdk bot commented Feb 28, 2024

openjdk bot commented Feb 28, 2024

8326763: Consolidate print methods in ContiguousSpace #18022

8326763: Consolidate print methods in ContiguousSpace #18022

Conversation

albertnetymk commented Feb 27, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Feb 27, 2024

openjdk bot commented Feb 27, 2024

mlbridge bot commented Feb 27, 2024 • edited Loading

Webrevs

stefank Feb 27, 2024

Choose a reason for hiding this comment

lgxbslgx left a comment

Choose a reason for hiding this comment

lgxbslgx Feb 28, 2024

Choose a reason for hiding this comment

albertnetymk Feb 28, 2024

Choose a reason for hiding this comment

lgxbslgx Feb 28, 2024

Choose a reason for hiding this comment

openjdk bot commented Feb 28, 2024

albertnetymk commented Feb 28, 2024

openjdk bot commented Feb 28, 2024

openjdk bot commented Feb 28, 2024

albertnetymk commented Feb 27, 2024 •

edited by openjdk bot

Loading

mlbridge bot commented Feb 27, 2024 •

edited

Loading