8269428: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out

[viktorklang-ora]

As an intermediate fix to the test, switching to explicit usage of an ExecutorService seems to do the trick to make this test reliably pass.

With that said, this test (CHM::ToArray.java) seems to trigger an issue in ForkJoinPool, so that would need to be fixed separately.

Tagging @DougLea as an FYI. :)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8269428: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out (Bug - P4)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18023/head:pull/18023
$ git checkout pull/18023

Update a local copy of the PR:
$ git checkout pull/18023
$ git pull https://git.openjdk.org/jdk.git pull/18023/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18023

View PR using the GUI difftool:
$ git pr show -t 18023

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18023.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vklang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@viktorklang-ora The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (a073256a)
• 00: Full (1426b837)

[DougLea]

This change seems OK in terms of avoiding failures due to unrelated FJP and/or GC issues (for which it may be better to develop a separate test).

[jaikiran]

The intention of this ToArray as noted in the summary of this test is to verify the thread safety of the toArray() methods of collection views. As noted in the JBS issue, the reason why this test keeps timing out intermittently appears to be an issue in the ForkJoinPool and thus those timeouts aren't exposing any issues within toArray() implementations itself. So it seems fine that we are switching over to using a thread pool that doesn't exhibit those issues.

This proposed change looks good to me. Since Doug has already approved this too, I will go ahead and officially mark this as reviewed.

Before integrating, please update the copyright year on this file.

[openjdk]

@viktorklang-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269428: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 210 new commits pushed to the master branch:

• 53c4714: 8327501: Common ForkJoinPool prevents class unloading in some cases
• 1261740: 8327283: RISC-V: Minimal build failed after JDK-8319716
• f54e598: 8327172: C2 SuperWord: data node in loop has no input in loop: replace assert with bailout
• 4018341: 8327379: Make TimeLinearScan a develop flag
• 1bd4abf: 8327434: Test java/util/PluggableLocale/TimeZoneNameProviderTest.java timed out
• ddcd6de: 8325532: serviceability/dcmd/compiler/PerfMapTest.java leaves created files in the /tmp dir.
• 3d37b28: 8327173: HotSpot Style Guide needs update regarding nullptr vs NULL
• 989fc3e: 8325878: Require minimum Clang version 13
• 13c7453: 8325880: Require minimum Open XL C/C++ version 17.1.1
• 4f33608: 8326718: Test java/util/Formatter/Padding.java should timeout on large inputs before fix in JDK-8299677
• ... and 200 more: https://git.openjdk.org/jdk/compare/5c5a282f91dd28b306673ca2bcc30dec451e7a7d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jaikiran]

Hello Viktor, Doug,

failures due to unrelated FJP and/or GC issues (for which it may be better to develop a separate test).

Since the test has (unintentionally) exposed an issue within the ForkJoinPool, should we open a separate issue to track that (or do we already have one)?

[viktorklang-ora]

Thanks @jaikiran, I have issued another commit: updating the copyright year

[viktorklang-ora]

@jaikiran I suspect that we might already have a JBS issue which relates to the FJP bug itself, but I'll have to go find it first. I'll sync with Doug next week.

[jaikiran]

@jaikiran I suspect that we might already have a JBS issue which relates to the FJP bug itself, but I'll have to go find it first. I'll sync with Doug next week.

Thank you - that sounds fine to me.

[viktorklang-ora]

/integrate

[openjdk]

Going to push as commit 570ad67.
Since your change was applied there have been 241 commits pushed to the master branch:

• 63dd6d1: 8327387: G1: Refactor region liveness processing after completion of concurrent marking
• f2b5ffd: 8326578: Clean up networking properties documentation
• ca5ca85: 8325651: C2 SuperWord: refactor the dependency graph
• d451f81: 8326381: com.sun.net.httpserver.HttpsParameters and SSLStreams incorrectly handle needClientAuth and wantClientAuth
• 243cb09: 8327389: Remove use of HOTSPOT_BUILD_USER
• 2d4c757: 8327041: Incorrect lane size references in avx512 instructions.
• 761ed25: 8327138: Clean up status management in cdsConfig.hpp and CDS.java
• 53628f2: 8327492: Remove applet usage and update DisposeInActionEventTest.html
• 2627470: 8325567: jspawnhelper without args fails with segfault
• a6dc4bc: 8326332: Unclosed inline tags cause misalignment in summary tables
• ... and 231 more: https://git.openjdk.org/jdk/compare/5c5a282f91dd28b306673ca2bcc30dec451e7a7d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@viktorklang-ora Pushed as commit 570ad67.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.