8326824: Test: remove redundant test in compiler/vectorapi/reshape/utils/TestCastMethods.java

[Hamlin-Li]

Hi,
Can you review this simple patch to remove redundant test?
Thanks.

FYI: makePair(FSPEC128, ISPEC128), is tested twice unnecessarily, so this is to remove the redundant one.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8326824: Test: remove redundant test in compiler/vectorapi/reshape/utils/TestCastMethods.java (Enhancement - P5)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18027/head:pull/18027
$ git checkout pull/18027

Update a local copy of the PR:
$ git checkout pull/18027
$ git pull https://git.openjdk.org/jdk.git pull/18027/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18027

View PR using the GUI difftool:
$ git pr show -t 18027

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18027.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Hamlin-Li The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (88020575)

[vnkozlov]

Is it because there is such test already at line 62?

[vnkozlov]

@Hamlin-Li You need to explain motivation for changes in RFE's Description and here for reviewers avoid to guess why you do that.

[Hamlin-Li]

Is it because there is such test already at line 62?

Yes.

You need to explain motivation for changes in RFE's Description and here for reviewers avoid to guess why you do that.

Added, thanks for reminding.

[vnkozlov]

Good and trivial.

[openjdk]

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326824: Test: remove redundant test in compiler/vectorapi/reshape/utils/TestCastMethods.java

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

• 9f0e7da: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop
• 81b065a: 8326714: Make file-local functions static in src/java.base/unix/native/libjava/childproc.c
• 4fcae1a: 8326722: Cleanup unnecessary forward declaration in collectedHeap.hpp
• c5c866a: 8326219: applications/kitchensink/Kitchensink8H.java timed out
• ac3ce2a: 8326583: Remove over-generalized DefineNativeToolchain solution
• bceaed6: 8326406: Remove mapfile support from makefiles
• 16d917a: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump
• 60cbf29: 8325754: Dead AbstractQueuedSynchronizer$ConditionNodes survive minor garbage collections
• da14aa4: 8017234: Hotspot should stop using mapfiles
• d482c1a: 8326524: Rename agent_common.h
• ... and 32 more: https://git.openjdk.org/jdk/compare/09a78b5da961f3575cf20c9b56bff86ddbd6545d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[Hamlin-Li]

Thanks @vnkozlov for your review.

/integrate

[openjdk]

Going to push as commit 552411f.
Since your change was applied there have been 42 commits pushed to the master branch:

• 9f0e7da: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop
• 81b065a: 8326714: Make file-local functions static in src/java.base/unix/native/libjava/childproc.c
• 4fcae1a: 8326722: Cleanup unnecessary forward declaration in collectedHeap.hpp
• c5c866a: 8326219: applications/kitchensink/Kitchensink8H.java timed out
• ac3ce2a: 8326583: Remove over-generalized DefineNativeToolchain solution
• bceaed6: 8326406: Remove mapfile support from makefiles
• 16d917a: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump
• 60cbf29: 8325754: Dead AbstractQueuedSynchronizer$ConditionNodes survive minor garbage collections
• da14aa4: 8017234: Hotspot should stop using mapfiles
• d482c1a: 8326524: Rename agent_common.h
• ... and 32 more: https://git.openjdk.org/jdk/compare/09a78b5da961f3575cf20c9b56bff86ddbd6545d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@Hamlin-Li Pushed as commit 552411f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.