-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests #18037
Conversation
👋 Welcome back elifaslan1! A progress list of the required criteria for merging this PR into |
@lmesnik could you please test this to your system and report the results? TIA |
@elifaslan1 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
/integrate |
@elifaslan1 This pull request has not yet been marked as ready for integration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but we need @lmesnik to bless this integration.
/reviewers 2
@elifaslan1 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 22 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@lgxbslgx, @shipilev, @lmesnik) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@elifaslan1 |
/sponsor |
Going to push as commit d9aa1de.
Your commit was automatically rebased without conflicts. |
@phohensee @elifaslan1 Pushed as commit d9aa1de. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The commit includes changes to unblock parallelism vmTestbase/nsk/stress/stack tests.
GHA tested.
Command below succeeded
make test TEST=vmTestbase/nsk/stress/stack JTREG=REPEAT_COUNT=100
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18037/head:pull/18037
$ git checkout pull/18037
Update a local copy of the PR:
$ git checkout pull/18037
$ git pull https://git.openjdk.org/jdk.git pull/18037/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18037
View PR using the GUI difftool:
$ git pr show -t 18037
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18037.diff
Webrev
Link to Webrev Comment