Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests #18037

Closed
wants to merge 1 commit into from

Conversation

elifaslan1
Copy link
Contributor

@elifaslan1 elifaslan1 commented Feb 28, 2024

The commit includes changes to unblock parallelism vmTestbase/nsk/stress/stack tests.
GHA tested.
Command below succeeded
make test TEST=vmTestbase/nsk/stress/stack JTREG=REPEAT_COUNT=100


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18037/head:pull/18037
$ git checkout pull/18037

Update a local copy of the PR:
$ git checkout pull/18037
$ git pull https://git.openjdk.org/jdk.git pull/18037/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18037

View PR using the GUI difftool:
$ git pr show -t 18037

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18037.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2024

👋 Welcome back elifaslan1! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@elifaslan1
Copy link
Contributor Author

@lmesnik could you please test this to your system and report the results? TIA

@openjdk
Copy link

openjdk bot commented Feb 28, 2024

@elifaslan1 The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Feb 28, 2024
@elifaslan1 elifaslan1 changed the title JDK-8318605:Enable parallelism in vmTestbase/nsk/stress/stack tests 8318605:Enable parallelism in vmTestbase/nsk/stress/stack tests Feb 28, 2024
@elifaslan1 elifaslan1 changed the title 8318605:Enable parallelism in vmTestbase/nsk/stress/stack tests 8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests Feb 28, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 28, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2024

Webrevs

Copy link
Member

@lgxbslgx lgxbslgx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@elifaslan1
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 28, 2024

@elifaslan1 This pull request has not yet been marked as ready for integration.

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we need @lmesnik to bless this integration.

/reviewers 2

@openjdk
Copy link

openjdk bot commented Feb 28, 2024

@elifaslan1 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests

Reviewed-by: gli, shade, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • bbfda65: 8326897: (fs) The utility TestUtil.supportsLinks is wrongly used to check for hard link support
  • db0e2b8: 8326944: (ch) Minor typo in the ScatteringByteChannel.read(ByteBuffer[] dsts,int offset,int length) javadoc
  • 8f6edd8: 8326975: Parallel: Remove redundant PSOldGen::is_allocated
  • 4302900: 8319673: Few security tests ignore VM flags
  • e772e78: 8326948: Force English locale for timeout formatting
  • d9ef16d: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns
  • 998d0ba: 8324799: Use correct extension for C++ test headers
  • 0735c8a: 8318302: ThreadCountLimit.java failed with "Native memory allocation (mprotect) failed to protect 16384 bytes for memory to guard stack pages"
  • 5fa2bdc: 8326953: Race in creation of win-exports.def with static-libs
  • be2b92b: 8326694: Defer setting of autocapitalize attribute
  • ... and 12 more: https://git.openjdk.org/jdk/compare/4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@lgxbslgx, @shipilev, @lmesnik) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 28, 2024
@openjdk
Copy link

openjdk bot commented Feb 28, 2024

@shipilev
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@elifaslan1
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 29, 2024
@openjdk
Copy link

openjdk bot commented Feb 29, 2024

@elifaslan1
Your change (at version ba26d61) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 29, 2024

Going to push as commit d9aa1de.
Since your change was applied there have been 22 commits pushed to the master branch:

  • bbfda65: 8326897: (fs) The utility TestUtil.supportsLinks is wrongly used to check for hard link support
  • db0e2b8: 8326944: (ch) Minor typo in the ScatteringByteChannel.read(ByteBuffer[] dsts,int offset,int length) javadoc
  • 8f6edd8: 8326975: Parallel: Remove redundant PSOldGen::is_allocated
  • 4302900: 8319673: Few security tests ignore VM flags
  • e772e78: 8326948: Force English locale for timeout formatting
  • d9ef16d: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns
  • 998d0ba: 8324799: Use correct extension for C++ test headers
  • 0735c8a: 8318302: ThreadCountLimit.java failed with "Native memory allocation (mprotect) failed to protect 16384 bytes for memory to guard stack pages"
  • 5fa2bdc: 8326953: Race in creation of win-exports.def with static-libs
  • be2b92b: 8326694: Defer setting of autocapitalize attribute
  • ... and 12 more: https://git.openjdk.org/jdk/compare/4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 29, 2024
@openjdk openjdk bot closed this Feb 29, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 29, 2024
@openjdk
Copy link

openjdk bot commented Feb 29, 2024

@phohensee @elifaslan1 Pushed as commit d9aa1de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

5 participants