8326947: Minimize MakeBase.gmk

[magicus]

This is part of a general "spring cleaning" of the build system, addressing old code that has bit-rotted, been subject to lava flow, or just had bad or smelly code that we've never gotten around to fix.

This particular patch tries to make MakeBase truly minimal; only including the core parts of the build system that all makefiles will need. This is now limited to essential functionality for named parameter functions, variable dependency, tool execution, logging and fixpath functionality. MakeBase still includes Utils.gmk and FileUtils.gmk, and thus "provides" this functionality as well. Separating these out as well will be the subject of a future patch.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8326947: Minimize MakeBase.gmk (Bug - P4)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer) ⚠️ Review applies to 8c25c87c

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18041/head:pull/18041
$ git checkout pull/18041

Update a local copy of the PR:
$ git checkout pull/18041
$ git pull https://git.openjdk.org/jdk.git pull/18041/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18041

View PR using the GUI difftool:
$ git pr show -t 18041

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18041.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[magicus]

I have verified using COMPARE_BUILD on windows-x64, linux-x64, linux-aarch64, macosx-x64 and macosx-aarch64 that there are no differences in the resulting build.

[openjdk]

@magicus The following labels will be automatically applied to this pull request:

• build
• client
• compiler
• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 06: Full - Incremental (b6059e1a)
• 05: Full - Incremental (8c25c87c)
• 04: Full - Incremental (bba3672d)
• 03: Full - Incremental (18bcf569)
• 02: Full - Incremental (47278b69)
• 01: Full (36bb38f0)
• 00: Full (3c86bcfe)

[magicus]

/label -client -compiler -core-libs

[openjdk]

@magicus
The client label was successfully removed.

The compiler label was successfully removed.

The core-libs label was successfully removed.

[erikj79]

The distinction between Utils.gmk and BaseUtils.gmk seems a bit arbitrary at a glance, especially since both are still included from MakeBase.gmk. How would you know in which file to add a new macro?

[magicus]

The distinction was that BaseUtils.gmk are needed for MakeBase.gmk, Utils.gmk and FileUtils.gmk, but these three are not dependent on anything else. My initial goal was to stop having MakeBase.gmk include Utils.gmk as well, but it required a lot of extra includes and I did not want to do that in this PR. (Maybe it is not a good idea at all; I have not yet really decided).

I agree that the split seems a bit arbitrary. Maybe it was a bad idea. Let me ponder it for a while.

[openjdk]

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326947: Minimize MakeBase.gmk

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• ecc603c: 8201183: sjavac build failures: "Connection attempt failed: Connection refused"
• ff5c9a4: 8329528: G1 does not update TAMS correctly when dropping retained regions during Concurrent Start pause

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bridgekeeper]

@magicus This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[erikj79]

Looks good now.

[magicus]

/integrate

[openjdk]

Going to push as commit 1606187.
Since your change was applied there have been 4 commits pushed to the master branch:

• 2e3682a: 8319678: Several tests from corelibs areas ignore VM flags
• 63684cd: 8327250: assert(!method->is_old()) failed: Should not be installing old methods
• ecc603c: 8201183: sjavac build failures: "Connection attempt failed: Connection refused"
• ff5c9a4: 8329528: G1 does not update TAMS correctly when dropping retained regions during Concurrent Start pause

Your commit was automatically rebased without conflicts.

[openjdk]

@magicus Pushed as commit 1606187.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.