Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8326959: Improve JVMCI option help #18045

Closed
wants to merge 6 commits into from
Closed

Conversation

dougxc
Copy link
Member

@dougxc dougxc commented Feb 28, 2024

This PR improves the wording and layout of JVMCI options exposed to users.
All other JVMCI options are no longer included in the output of -XX:+JVMCIPrintProperties.

> java -XX:+JVMCIPrintProperties
[JVMCI properties]
jvmci.Compiler = null                                                     [String]
          Selects the system compiler. This must match the getCompilerName() value
          returned by a jdk.vm.ci.runtime.JVMCICompilerFactory provider.
          An empty string or the value "null" selects a compiler
          that raises an exception upon receiving a compilation request.

jvmci.PrintConfig = false                                                [Boolean]
          Prints VM values (e.g. flags, constants, field offsets etc) exposed to JVMCI.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8326959: Improve JVMCI option help (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18045/head:pull/18045
$ git checkout pull/18045

Update a local copy of the PR:
$ git checkout pull/18045
$ git pull https://git.openjdk.org/jdk.git pull/18045/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18045

View PR using the GUI difftool:
$ git pr show -t 18045

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18045.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2024

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 28, 2024
@openjdk
Copy link

openjdk bot commented Feb 28, 2024

@dougxc The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Feb 28, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2024

Webrevs

@openjdk openjdk bot removed the rfr Pull request is ready for review label Feb 28, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 28, 2024
@openjdk
Copy link

openjdk bot commented Feb 28, 2024

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326959: Improve JVMCI option help

Reviewed-by: never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 28, 2024
@dougxc
Copy link
Member Author

dougxc commented Feb 29, 2024

Thanks for the review Tom.

/integrate

@openjdk
Copy link

openjdk bot commented Feb 29, 2024

Going to push as commit 43af120.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 29, 2024
@openjdk openjdk bot closed this Feb 29, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 29, 2024
@openjdk
Copy link

openjdk bot commented Feb 29, 2024

@dougxc Pushed as commit 43af120.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants