Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258490: Shenandoah: Full GC does not need to remark threads and drain SATB buffers #1805

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Dec 16, 2020

Full GC marks heap at a pause with SATB deactivated, therefore, we don't need to remark threads and drain SATB buffers during final mark phase.

  • hotspot_gc_shenandoah

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258490: Shenandoah: Full GC does not need to remark threads and drain SATB buffers

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1805/head:pull/1805
$ git checkout pull/1805

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2020

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 16, 2020
@openjdk
Copy link

openjdk bot commented Dec 16, 2020

@zhengyu123 The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Dec 16, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 16, 2020

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, modulo minor nit.

@@ -225,6 +225,18 @@ void ShenandoahProcessConcurrentRootsTask<T>::work(uint worker_id) {
_rs.oops_do(&cl, worker_id);
}

class ShenandoahClaimThreadClosure : public ThreadClosure {
private:
uintx _claim_token;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be const, maybe?

@openjdk
Copy link

openjdk bot commented Jan 4, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258490: Shenandoah: Full GC does not need to remark threads and drain SATB buffers

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 149 new commits pushed to the master branch:

  • d679caa: 8196466: javax/swing/JFileChooser/8062561/bug8062561.java fails
  • a2a3f4a: 8258924: javax/swing/JSplitPane/4201995/bug4201995.java fails in GTk L&F
  • f351e15: 8258382: Fix optimization-unstable code involving pointer overflow
  • 526c000: 8255729: com.sun.tools.javac.processing.JavacFiler.FilerOutputStream is inefficient
  • 497efef: 8225116: Test OwnedWindowsLeak.java intermittently fails
  • f5ee356: 8179503: Java should support GET OCSP calls
  • 8435f0d: 8258525: Some existing tests should use /nodynamiccopyright/ instead of the standard header
  • 07c93fa: Merge
  • 881bceb: 8258662: JDK 17ea: Crash compiling instanceof check involving sealed interface
  • fb607f1: 8245922: [macos] Taskbar.Feature.ICON_BADGE_NUMBER no longer supported on MacOS
  • ... and 139 more: https://git.openjdk.java.net/jdk/compare/a372be4ba2216adb325f7616e54c1d58ac8fdf2a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 4, 2021
@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Jan 4, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 4, 2021
@openjdk
Copy link

openjdk bot commented Jan 4, 2021

@zhengyu123 Since your change was applied there have been 150 commits pushed to the master branch:

  • 7f04d23: 8258800: Deprecate -XX:+AlwaysLockClassLoader
  • d679caa: 8196466: javax/swing/JFileChooser/8062561/bug8062561.java fails
  • a2a3f4a: 8258924: javax/swing/JSplitPane/4201995/bug4201995.java fails in GTk L&F
  • f351e15: 8258382: Fix optimization-unstable code involving pointer overflow
  • 526c000: 8255729: com.sun.tools.javac.processing.JavacFiler.FilerOutputStream is inefficient
  • 497efef: 8225116: Test OwnedWindowsLeak.java intermittently fails
  • f5ee356: 8179503: Java should support GET OCSP calls
  • 8435f0d: 8258525: Some existing tests should use /nodynamiccopyright/ instead of the standard header
  • 07c93fa: Merge
  • 881bceb: 8258662: JDK 17ea: Crash compiling instanceof check involving sealed interface
  • ... and 140 more: https://git.openjdk.java.net/jdk/compare/a372be4ba2216adb325f7616e54c1d58ac8fdf2a...master

Your commit was automatically rebased without conflicts.

Pushed as commit f80c63b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zhengyu123 zhengyu123 deleted the JDK-8258490-fullgc-remark branch March 9, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
2 participants