8326838: JFR: Native mirror events

[egahlin]

Hi,

Could I have a review of a change that provides infrastructure for emitting JDK events with metadata defined in native, such as structs, enum constants and references to native artefacts. If an event in the JDK has the same name as an event defined in metadata.xml, the metadata for the native event is used.

I also fixed an incorrect exception message in the TypeLibrary class.

Testing: jdk/jdk/jfr and manual validatation that native metadata is picked up by a JDK event.

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8326838: JFR: Native mirror events (Enhancement - P3)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18051/head:pull/18051
$ git checkout pull/18051

Update a local copy of the PR:
$ git checkout pull/18051
$ git pull https://git.openjdk.org/jdk.git pull/18051/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18051

View PR using the GUI difftool:
$ git pr show -t 18051

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18051.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (7ebc19b8)
• 00: Full (50cddb30)

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326838: JFR: Native mirror events

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• 4302900: 8319673: Few security tests ignore VM flags
• e772e78: 8326948: Force English locale for timeout formatting
• d9ef16d: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns
• 998d0ba: 8324799: Use correct extension for C++ test headers
• 0735c8a: 8318302: ThreadCountLimit.java failed with "Native memory allocation (mprotect) failed to protect 16384 bytes for memory to guard stack pages"
• 5fa2bdc: 8326953: Race in creation of win-exports.def with static-libs
• be2b92b: 8326694: Defer setting of autocapitalize attribute
• 38ad514: 8326687: Inconsistent use of "ZIP", "Zip" and "zip" in java.util.zip/jar zipfs javadoc
• b938a5c: 8324969: C2: prevent elimination of unbalanced coarsened locking regions
• a93605f: 8326763: Consolidate print methods in ContiguousSpace
• ... and 17 more: https://git.openjdk.org/jdk/compare/c5c866aafe76f51cd5386bf5052c06691c1a0e8c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit d29cefb.
Since your change was applied there have been 32 commits pushed to the master branch:

• b8fc418: 8326525: com/sun/tools/attach/BasicTests.java does not verify AgentLoadException case
• d9aa1de: 8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests
• bbfda65: 8326897: (fs) The utility TestUtil.supportsLinks is wrongly used to check for hard link support
• db0e2b8: 8326944: (ch) Minor typo in the ScatteringByteChannel.read(ByteBuffer[] dsts,int offset,int length) javadoc
• 8f6edd8: 8326975: Parallel: Remove redundant PSOldGen::is_allocated
• 4302900: 8319673: Few security tests ignore VM flags
• e772e78: 8326948: Force English locale for timeout formatting
• d9ef16d: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns
• 998d0ba: 8324799: Use correct extension for C++ test headers
• 0735c8a: 8318302: ThreadCountLimit.java failed with "Native memory allocation (mprotect) failed to protect 16384 bytes for memory to guard stack pages"
• ... and 22 more: https://git.openjdk.org/jdk/compare/c5c866aafe76f51cd5386bf5052c06691c1a0e8c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit d29cefb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.