8327002: (fs) java/nio/file/Files/CopyMoveVariations.java should be able to test across file systems

[bplb]

1. Modify the test to allow specifying the location of the temporary directory to be distinct from that of the working directory.
2. Correctly handle the responses to AccessDeniedExceptions which occur when a move across different file systems fails.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8327002: (fs) java/nio/file/Files/CopyMoveVariations.java should be able to test across file systems (Enhancement - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18052/head:pull/18052
$ git checkout pull/18052

Update a local copy of the PR:
$ git checkout pull/18052
$ git pull https://git.openjdk.org/jdk.git pull/18052/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18052

View PR using the GUI difftool:
$ git pr show -t 18052

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18052.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[bplb]

1. Add property copymove.tmp.dir which can be set to specify the temporary file directory. The property java.io.tmpdir is not used as it is always defined.
2. Correct handling of AccessDeniedExceptions occurring for Files.move when the source is a directory or a file and the move is to a different file system.
3. Rename various local variables.

[mlbridge]

Webrevs

• 00: Full (e76853bc)

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327002: (fs) java/nio/file/Files/CopyMoveVariations.java should be able to test across file systems

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 454 new commits pushed to the master branch:

• 816638e: 8329352: Remove dead code in splashscreen_sys.c
• 3d22838: 8328997: Remove unnecessary template parameter lists in GrowableArray
• 5cddc2d: 8325252: C2 SuperWord: refactor the packset
• 6b1b0e9: 8329103: assert(!thread->in_asgct()) failed during multi-mode profiling
• bc546c2: 8328561: test java/awt/Robot/ManualInstructions/ManualInstructions.java isn't used
• af7c6af: 8324808: Manual printer tests have no Pass/Fail buttons, instructions close set 3
• d3fc8df: 8329135: Store Universe::*exception_instance() in CDS archive
• a85c849: 8328273: sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java failed with java.rmi.server.ExportException: Port already in use
• 70c8ff1: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout
• ecd2b71: 8329354: java/text/Format/MessageFormat/CompactSubFormats.java fails
• ... and 444 more: https://git.openjdk.org/jdk/compare/38ad514589764d16b312152474e2446c3339da39...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bplb]

/integrate

[openjdk]

Going to push as commit dd5d7d0.
Since your change was applied there have been 462 commits pushed to the master branch:

• 6ae1cf1: 8329368: Generational ZGC: Remove the unnecessary friend classes in ZAllocator
• 7eb78e3: 8320676: Manual printer tests have no Pass/Fail buttons, instructions close set 1
• 5ac067f: 8329289: Unify SetupJdkExecutable and SetupJdkLibrary
• 5ae849d: 8329292: Fix missing cleanups in java.management and jdk.management
• ed821cb: 8324807: Manual printer tests have no Pass/Fail buttons, instructions close set 2
• 5cf457b: 8329320: Simplify awt/print/PageFormat/NullPaper.java test
• 8b934aa: 8329358: Generational ZGC: Remove the unused method ZPointer::set_remset_bits
• 3b582df: 8051959: Add thread and timestamp options to java.security.debug system property
• 816638e: 8329352: Remove dead code in splashscreen_sys.c
• 3d22838: 8328997: Remove unnecessary template parameter lists in GrowableArray
• ... and 452 more: https://git.openjdk.org/jdk/compare/38ad514589764d16b312152474e2446c3339da39...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit dd5d7d0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.