-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14 #18058
Conversation
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
@prsadhuk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label add client |
@prsadhuk |
@prsadhuk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
/integrate |
Going to push as commit 0d35450.
Your commit was automatically rebased without conflicts. |
/backport jdk21u-dev |
@prsadhuk Could not automatically backport
Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk21u-dev. Note: these commands are just some suggestions and you can use other equivalent commands you know.
Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk21u-dev with the title Below you can find a suggestion for the pull request body:
|
/backport jdk22u-dev |
@prsadhuk The target repository |
/backport jdk22u |
@prsadhuk the backport was successfully created on the branch backport-prsadhuk-0d354503 in my personal fork of openjdk/jdk22u. To create a pull request with this backport targeting openjdk/jdk22u:master, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22u:
|
javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java is failing in macos14 due to apple os upgrade. More information in JDK-8316151
problemlist the test for now..
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18058/head:pull/18058
$ git checkout pull/18058
Update a local copy of the PR:
$ git checkout pull/18058
$ git pull https://git.openjdk.org/jdk.git pull/18058/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18058
View PR using the GUI difftool:
$ git pr show -t 18058
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18058.diff
Webrev
Link to Webrev Comment