Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14 #18058

Closed
wants to merge 1 commit into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Feb 29, 2024

javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java is failing in macos14 due to apple os upgrade. More information in JDK-8316151
problemlist the test for now..


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18058/head:pull/18058
$ git checkout pull/18058

Update a local copy of the PR:
$ git checkout pull/18058
$ git pull https://git.openjdk.org/jdk.git pull/18058/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18058

View PR using the GUI difftool:
$ git pr show -t 18058

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18058.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 29, 2024

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 29, 2024
@openjdk
Copy link

openjdk bot commented Feb 29, 2024

@prsadhuk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@prsadhuk
Copy link
Contributor Author

/label add client

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Feb 29, 2024
@openjdk
Copy link

openjdk bot commented Feb 29, 2024

@prsadhuk
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Feb 29, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 29, 2024

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14

Reviewed-by: prr, gli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 8d6f784: 8327056: Remove unused static char array in JvmtiAgentList::lookup
  • 43af120: 8326959: Improve JVMCI option help
  • 742c776: 8322743: C2: prevent lock region elimination in OSR compilation
  • d29cefb: 8326838: JFR: Native mirror events
  • b8fc418: 8326525: com/sun/tools/attach/BasicTests.java does not verify AgentLoadException case
  • d9aa1de: 8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests
  • bbfda65: 8326897: (fs) The utility TestUtil.supportsLinks is wrongly used to check for hard link support
  • db0e2b8: 8326944: (ch) Minor typo in the ScatteringByteChannel.read(ByteBuffer[] dsts,int offset,int length) javadoc
  • 8f6edd8: 8326975: Parallel: Remove redundant PSOldGen::is_allocated
  • 4302900: 8319673: Few security tests ignore VM flags
  • ... and 2 more: https://git.openjdk.org/jdk/compare/998d0baab0fd051c38d9fd6021628eb863b80554...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 29, 2024
Copy link
Member

@lgxbslgx lgxbslgx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@prsadhuk
Copy link
Contributor Author

prsadhuk commented Mar 1, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 1, 2024

Going to push as commit 0d35450.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 8d6f784: 8327056: Remove unused static char array in JvmtiAgentList::lookup
  • 43af120: 8326959: Improve JVMCI option help
  • 742c776: 8322743: C2: prevent lock region elimination in OSR compilation
  • d29cefb: 8326838: JFR: Native mirror events
  • b8fc418: 8326525: com/sun/tools/attach/BasicTests.java does not verify AgentLoadException case
  • d9aa1de: 8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests
  • bbfda65: 8326897: (fs) The utility TestUtil.supportsLinks is wrongly used to check for hard link support
  • db0e2b8: 8326944: (ch) Minor typo in the ScatteringByteChannel.read(ByteBuffer[] dsts,int offset,int length) javadoc
  • 8f6edd8: 8326975: Parallel: Remove redundant PSOldGen::is_allocated
  • 4302900: 8319673: Few security tests ignore VM flags
  • ... and 2 more: https://git.openjdk.org/jdk/compare/998d0baab0fd051c38d9fd6021628eb863b80554...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 1, 2024
@openjdk openjdk bot closed this Mar 1, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 1, 2024
@openjdk
Copy link

openjdk bot commented Mar 1, 2024

@prsadhuk Pushed as commit 0d35450.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8327040 branch March 1, 2024 03:10
@prsadhuk
Copy link
Contributor Author

/backport jdk21u-dev

@openjdk
Copy link

openjdk bot commented Mar 15, 2024

@prsadhuk Could not automatically backport 0d354503 to openjdk/jdk21u-dev due to conflicts in the following files:

  • test/jdk/ProblemList.txt

Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk21u-dev. Note: these commands are just some suggestions and you can use other equivalent commands you know.

# Fetch the up-to-date version of the target branch
$ git fetch --no-tags https://git.openjdk.org/jdk21u-dev.git master:master

# Check out the target branch and create your own branch to backport
$ git checkout master
$ git checkout -b backport-prsadhuk-0d354503

# Fetch the commit you want to backport
$ git fetch --no-tags https://git.openjdk.org/jdk.git 0d354503620eb7f6da7b1b8aa6143ba18ced8f12

# Backport the commit
$ git cherry-pick --no-commit 0d354503620eb7f6da7b1b8aa6143ba18ced8f12
# Resolve conflicts now

# Commit the files you have modified
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport 0d354503620eb7f6da7b1b8aa6143ba18ced8f12'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk21u-dev with the title Backport 0d354503620eb7f6da7b1b8aa6143ba18ced8f12.

Below you can find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 0d354503 from the openjdk/jdk repository.

The commit being backported was authored by Prasanta Sadhukhan on 1 Mar 2024 and was reviewed by Phil Race and Guoxiong Li.

Thanks!

@prsadhuk
Copy link
Contributor Author

/backport jdk22u-dev

@openjdk
Copy link

openjdk bot commented Mar 15, 2024

@prsadhuk The target repository jdk22u-dev is not a valid target for backports.
List of valid target repositories: openjdk/jdk, openjdk/jdk11u, openjdk/jdk11u-dev, openjdk/jdk17u, openjdk/jdk17u-dev, openjdk/jdk21u, openjdk/jdk21u-dev, openjdk/jdk22, openjdk/jdk22u, openjdk/jdk7u, openjdk/jdk8u, openjdk/jdk8u-dev, openjdk/jfx, openjdk/jfx17u, openjdk/jfx21u, openjdk/jfx22u, openjdk/lilliput-jdk17u, openjdk/lilliput-jdk21u, openjdk/shenandoah-jdk21u, openjdk/shenandoah-jdk8u.
Supplying the organization/group prefix is optional.

@prsadhuk
Copy link
Contributor Author

/backport jdk22u

@openjdk
Copy link

openjdk bot commented Mar 15, 2024

@prsadhuk the backport was successfully created on the branch backport-prsadhuk-0d354503 in my personal fork of openjdk/jdk22u. To create a pull request with this backport targeting openjdk/jdk22u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 0d354503 from the openjdk/jdk repository.

The commit being backported was authored by Prasanta Sadhukhan on 1 Mar 2024 and was reviewed by Phil Race and Guoxiong Li.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22u:

$ git fetch https://github.com/openjdk-bots/jdk22u.git backport-prsadhuk-0d354503:backport-prsadhuk-0d354503
$ git checkout backport-prsadhuk-0d354503
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22u.git backport-prsadhuk-0d354503

⚠️ @prsadhuk You are not yet a collaborator in my fork openjdk-bots/jdk22u. An invite will be sent out and you need to accept it before you can proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants