Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325361: Make sun.net.www.MessageHeader final #18060

Closed
wants to merge 1 commit into from

Conversation

Korov
Copy link
Contributor

@Korov Korov commented Feb 29, 2024

Make sun.net.www.MessageHeader final, and remove @SuppressWarnings("this-escape")


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8325361: Make sun.net.www.MessageHeader final (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18060/head:pull/18060
$ git checkout pull/18060

Update a local copy of the PR:
$ git checkout pull/18060
$ git pull https://git.openjdk.org/jdk.git pull/18060/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18060

View PR using the GUI difftool:
$ git pr show -t 18060

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18060.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 29, 2024

👋 Welcome back Korov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 29, 2024

@Korov The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added net net-dev@openjdk.org rfr Pull request is ready for review labels Feb 29, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 29, 2024

Webrevs

Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me @Korov . Give me some time to send that change to our test farms and double check it causes no issues.

@Korov
Copy link
Contributor Author

Korov commented Feb 29, 2024

This looks good to me @Korov . Give me some time to send that change to our test farms and double check it causes no issues.

Thanks.

Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test results came back green. So please integrate!

@openjdk
Copy link

openjdk bot commented Feb 29, 2024

@Korov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325361: Make sun.net.www.MessageHeader final

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 8d6f784: 8327056: Remove unused static char array in JvmtiAgentList::lookup
  • 43af120: 8326959: Improve JVMCI option help
  • 742c776: 8322743: C2: prevent lock region elimination in OSR compilation
  • d29cefb: 8326838: JFR: Native mirror events
  • b8fc418: 8326525: com/sun/tools/attach/BasicTests.java does not verify AgentLoadException case
  • d9aa1de: 8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests
  • bbfda65: 8326897: (fs) The utility TestUtil.supportsLinks is wrongly used to check for hard link support
  • db0e2b8: 8326944: (ch) Minor typo in the ScatteringByteChannel.read(ByteBuffer[] dsts,int offset,int length) javadoc
  • 8f6edd8: 8326975: Parallel: Remove redundant PSOldGen::is_allocated
  • 4302900: 8319673: Few security tests ignore VM flags
  • ... and 2 more: https://git.openjdk.org/jdk/compare/998d0baab0fd051c38d9fd6021628eb863b80554...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 29, 2024
@Korov
Copy link
Contributor Author

Korov commented Mar 1, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 1, 2024
@openjdk
Copy link

openjdk bot commented Mar 1, 2024

@Korov
Your change (at version 5658f99) is now ready to be sponsored by a Committer.

@Korov
Copy link
Contributor Author

Korov commented Mar 1, 2024

Hello @dfuch , sorry for replying so late, I'am not a committer so I need your help to execute the next commant /sponsor, thank you very much for your help.

@dfuch
Copy link
Member

dfuch commented Mar 1, 2024

/sponsor

@dfuch
Copy link
Member

dfuch commented Mar 1, 2024

@Korov : sponsored! Thanks for the fix :-)

@openjdk
Copy link

openjdk bot commented Mar 1, 2024

Going to push as commit e85265a.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 5b75199: 8327022: Parallel: Remove experimental dense prefix calculation
  • a065eba: 8326496: [test] checkHsErrFileContent support printing hserr in error case
  • 0899b3b: 8326612: Parallel: remove redundant assertion from ScavengeRootsTask
  • 12404a5: 8324790: ifnode::fold_compares_helper cleanup
  • 0d35450: 8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14
  • 8d6f784: 8327056: Remove unused static char array in JvmtiAgentList::lookup
  • 43af120: 8326959: Improve JVMCI option help
  • 742c776: 8322743: C2: prevent lock region elimination in OSR compilation
  • d29cefb: 8326838: JFR: Native mirror events
  • b8fc418: 8326525: com/sun/tools/attach/BasicTests.java does not verify AgentLoadException case
  • ... and 7 more: https://git.openjdk.org/jdk/compare/998d0baab0fd051c38d9fd6021628eb863b80554...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 1, 2024
@openjdk openjdk bot closed this Mar 1, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 1, 2024
@openjdk
Copy link

openjdk bot commented Mar 1, 2024

@dfuch @Korov Pushed as commit e85265a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants