8327057: Parallel: Refactor ParMarkBitMap::iterate #18065
Conversation
|
👋 Welcome back ayang! A progress list of the required criteria for merging this PR into |
openjdk
bot
changed the title
|
@albertnetymk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
| if (range_beg < range_end && is_unmarked(range_beg)) { | ||
| // The range starts with dead space. Look for the next object, then fill. | ||
| // This must be the beginning of old/eden/from/to-space, so it's must be | ||
| // larger enough for a filler. |
There was a problem hiding this comment.
| // larger enough for a filler. | |
| // large enough for a filler. |
| const idx_t cur_end = find_obj_end(cur_beg, search_end); | ||
| if (cur_end >= range_end) { | ||
| // The obj ends outside the range. | ||
| live_closure->set_source(bit_to_addr(cur_beg)); |
There was a problem hiding this comment.
The caller of iterate expects live_closure->source() to be set at exit but the new code does not update it. It is in use in case of abnormal status.
This is not the case for the iterate taking two closures afaict, but nevertheless it seems part of the contract so it is surprising if some methods do and some do not.
The other changes seem to be okay.
There was a problem hiding this comment.
@albertnetymk mentioned that do_addr of MarkAndUpdateClosure properly updates the source of the closure.
|
@albertnetymk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 23 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
Thanks for review. /integrate |
|
Going to push as commit 045eea1.
Your commit was automatically rebased without conflicts. |
openjdk
bot
removed
ready
|
@albertnetymk Pushed as commit 045eea1. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
3 participants
Simplifying bitmap iterate logic in full-gc compaction to reduce possible outcomes callers must handle.
Test: tier1-6
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18065/head:pull/18065$ git checkout pull/18065Update a local copy of the PR:
$ git checkout pull/18065$ git pull https://git.openjdk.org/jdk.git pull/18065/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18065View PR using the GUI difftool:
$ git pr show -t 18065Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18065.diff
Webrev
Link to Webrev Comment