8326915: NPE when a validating parser is restricted

[JoeWang-Java]

Fix a NPE when a validating parser is restricted by the JDKCatalog resolve property. Also slightly improved the error msg with the catalog name.

Test: new test added
existing test CatalogSupport5 would fail without the Null check on ErrorReporter. It's a separate issue not covered by this fix.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8326915: NPE when a validating parser is restricted (Sub-task - P4)

Reviewers

• Lance Andersen (@LanceAndersen - Reviewer)
• Naoto Sato (@naotoj - Reviewer) ⚠️ Review applies to 6efb3c22

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18071/head:pull/18071
$ git checkout pull/18071

Update a local copy of the PR:
$ git checkout pull/18071
$ git pull https://git.openjdk.org/jdk.git pull/18071/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18071

View PR using the GUI difftool:
$ git pr show -t 18071

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18071.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back joehw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@JoeWang-Java The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (d847cf5d)
• 00: Full (6efb3c22)

[openjdk]

@JoeWang-Java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326915: NPE when a validating parser is restricted

Reviewed-by: lancea, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• b38a6c5: 8327049: Only export debug.cpp functions on Windows
• acc0a74: 8327126: Parallel: Remove unused ParMarkBitMapClosure::_initial_words_remaining
• 012411a: 8327046: (fs) Files.walk should be clear that depth-first traversal is pre-order
• 98434d6: 8322170: Update deprecated/obsolete/expired flags table for GC
• c02e7f4: 8327058: RISC-V: make Zcb experimental
• b972997: 8326974: ODR violation in macroAssembler_aarch64.cpp
• 437cf35: 8319648: java/lang/SecurityManager tests ignore vm flags
• e85265a: 8325361: Make sun.net.www.MessageHeader final
• 5b75199: 8327022: Parallel: Remove experimental dense prefix calculation
• a065eba: 8326496: [test] checkHsErrFileContent support printing hserr in error case
• ... and 5 more: https://git.openjdk.org/jdk/compare/742c776a922bc226a3beaa9e219ff0bd2baf7bc4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[naotoj]

LGTM

[naotoj]

Nit: the second argument is not needed.

[JoeWang-Java]

Thanks. Fixed. Also replaced the test's method name with a proper name.

[JoeWang-Java]

/integrate

[openjdk]

Going to push as commit a3d51d2.
Since your change was applied there have been 20 commits pushed to the master branch:

• f62f2ad: 8325671: Shenandoah: Introduce a ShenandoahGenerationType and templatize certain marking closures with it
• f68a4b9: 8327105: compiler.compilercontrol.share.scenario.Executor should listen on loopback address only
• a9c17a2: 8327108: compiler.lib.ir_framework.shared.TestFrameworkSocket should listen on loopback address only
• 7f02f07: 8316708: Augment WorstCaseTests with more cases
• 8f0fb27: 8327136: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java fails on libgraal
• b38a6c5: 8327049: Only export debug.cpp functions on Windows
• acc0a74: 8327126: Parallel: Remove unused ParMarkBitMapClosure::_initial_words_remaining
• 012411a: 8327046: (fs) Files.walk should be clear that depth-first traversal is pre-order
• 98434d6: 8322170: Update deprecated/obsolete/expired flags table for GC
• c02e7f4: 8327058: RISC-V: make Zcb experimental
• ... and 10 more: https://git.openjdk.org/jdk/compare/742c776a922bc226a3beaa9e219ff0bd2baf7bc4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@JoeWang-Java Pushed as commit a3d51d2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.