8327096: (fc) java/nio/channels/FileChannel/Size.java fails on partition incapable of creating large files

[bplb]

If an IOException with message "File too large" is thrown while testing with a large file, then ignore the exception if the type of the FileStore where the file would be located is "msdos".

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8327096: (fc) java/nio/channels/FileChannel/Size.java fails on partition incapable of creating large files (Bug - P4)

Reviewers

• Daniel Jeliński (@djelinski - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18073/head:pull/18073
$ git checkout pull/18073

Update a local copy of the PR:
$ git checkout pull/18073
$ git pull https://git.openjdk.org/jdk.git pull/18073/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18073

View PR using the GUI difftool:
$ git pr show -t 18073

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18073.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (eadd7331)
• 00: Full (42c2e315)

[djelinski]

Looks reasonable. Thanks.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327096: (fc) java/nio/channels/FileChannel/Size.java fails on partition incapable of creating large files

Reviewed-by: djelinski

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 120 new commits pushed to the master branch:

• e21da4c: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269
• 4d6235e: 8327716: RISC-V: Change type of vector_length param of several assembler functions from int to uint
• 586396c: 8327705: Remove mention of "applet" from java.text package description
• 41450e9: 8314250: CDS dump error message: Invoker type parameter must start and end with Object: L3I_L
• 0a6e64e: 8327424: ProblemList serviceability/sa/TestJmapCore.java on all platforms with ZGC
• c65d308: 8327812: JFR: Remove debug message in Function.Maximum
• b9bc31f: 8327790: Improve javadoc for ResolvedJavaType.hasFinalizableSubclass
• 18de932: 8325991: Accelerate Poly1305 on x86_64 using AVX2 instructions
• d74b907: 8327093: Add truncate function to BitMap API
• ffd43c9: 8327461: KeyStore getEntry is not thread-safe
• ... and 110 more: https://git.openjdk.org/jdk/compare/43af12039f13b884ab632ab403691530996e961c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bplb]

Looks reasonable. Thanks.

Thanks for reviewing!

[bplb]

/integrate

[openjdk]

Going to push as commit 94b4ed5.
Since your change was applied there have been 138 commits pushed to the master branch:

• b9c3dc3: 8327738: Remove unused internal method sun.n.w.p.h.HttpURLConnection.setDefaultAuthenticator
• 5b41466: 8327729: Remove deprecated xxxObject methods from jdk.internal.misc.Unsafe
• 313e814: 8324682: Remove redefinition of NULL for XLC compiler
• 8a3bdd5: 8327995: Remove unused Unused_Variable
• 201042f: 8327487: Further augment WorstCaseTests with more cases
• 379ad1f: 8312444: Delete unused parameters and variables in SocketPermission
• 782206b: 8327748: Convert javax/swing/JFileChooser/6798062/bug6798062.java applet test to main
• 0776fff: 8327794: RISC-V: enable extension features based on impid (Rivos specific change)
• cfd9209: 8327751: Convert javax/swing/JInternalFrame/6726866/bug6726866.java applet test to main
• 2cf3524: 8325433: Type annotations on primitive types are not linked
• ... and 128 more: https://git.openjdk.org/jdk/compare/43af12039f13b884ab632ab403691530996e961c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 94b4ed5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.