8327105: compiler.compilercontrol.share.scenario.Executor should listen on loopback address only

[jaikiran]

Can I please get a review of this test-only change which proposes to address https://bugs.openjdk.org/browse/JDK-8327105?

The commit here changes the internal test class compiler.compilercontrol.share.scenario.Executor to bind to a loopback address to prevent other hosts on the network to unexpected communicate on the ServerSocket.

The original interference was noticed in some tier7 tests which use this Executor class. With the change proposed in this PR, tier1, tier2, tier3 and tier7, tier8 have been run and that issue hasn't been noticed in this class anymore.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8327105: compiler.compilercontrol.share.scenario.Executor should listen on loopback address only (Enhancement - P4)

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18079/head:pull/18079
$ git checkout pull/18079

Update a local copy of the PR:
$ git checkout pull/18079
$ git pull https://git.openjdk.org/jdk.git pull/18079/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18079

View PR using the GUI difftool:
$ git pr show -t 18079

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18079.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (301631d5)

[chhagedorn]

That looks reasonable.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327105: compiler.compilercontrol.share.scenario.Executor should listen on loopback address only

Reviewed-by: chagedorn, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• b38a6c5: 8327049: Only export debug.cpp functions on Windows
• acc0a74: 8327126: Parallel: Remove unused ParMarkBitMapClosure::_initial_words_remaining
• 012411a: 8327046: (fs) Files.walk should be clear that depth-first traversal is pre-order
• 98434d6: 8322170: Update deprecated/obsolete/expired flags table for GC
• c02e7f4: 8327058: RISC-V: make Zcb experimental
• b972997: 8326974: ODR violation in macroAssembler_aarch64.cpp
• 437cf35: 8319648: java/lang/SecurityManager tests ignore vm flags
• e85265a: 8325361: Make sun.net.www.MessageHeader final
• 5b75199: 8327022: Parallel: Remove experimental dense prefix calculation
• a065eba: 8326496: [test] checkHsErrFileContent support printing hserr in error case
• ... and 1 more: https://git.openjdk.org/jdk/compare/12404a5efb3c45f72f54fda3238c72d5d15a30ee...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[vnkozlov]

Good.

[jaikiran]

Thank you for the reviews, Christian and Vladimir.

[jaikiran]

/integrate

[openjdk]

Going to push as commit f68a4b9.
Since your change was applied there have been 14 commits pushed to the master branch:

• a9c17a2: 8327108: compiler.lib.ir_framework.shared.TestFrameworkSocket should listen on loopback address only
• 7f02f07: 8316708: Augment WorstCaseTests with more cases
• 8f0fb27: 8327136: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java fails on libgraal
• b38a6c5: 8327049: Only export debug.cpp functions on Windows
• acc0a74: 8327126: Parallel: Remove unused ParMarkBitMapClosure::_initial_words_remaining
• 012411a: 8327046: (fs) Files.walk should be clear that depth-first traversal is pre-order
• 98434d6: 8322170: Update deprecated/obsolete/expired flags table for GC
• c02e7f4: 8327058: RISC-V: make Zcb experimental
• b972997: 8326974: ODR violation in macroAssembler_aarch64.cpp
• 437cf35: 8319648: java/lang/SecurityManager tests ignore vm flags
• ... and 4 more: https://git.openjdk.org/jdk/compare/12404a5efb3c45f72f54fda3238c72d5d15a30ee...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit f68a4b9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.