Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed." #18091

Closed
wants to merge 2 commits into from

Conversation

alisenchung
Copy link
Contributor

@alisenchung alisenchung commented Mar 1, 2024

Introduce delays in test to stabilize. Test passes 50x after fix.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed." (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18091/head:pull/18091
$ git checkout pull/18091

Update a local copy of the PR:
$ git checkout pull/18091
$ git pull https://git.openjdk.org/jdk.git pull/18091/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18091

View PR using the GUI difftool:
$ git pr show -t 18091

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18091.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 1, 2024

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 1, 2024
@openjdk
Copy link

openjdk bot commented Mar 1, 2024

@alisenchung The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 1, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 1, 2024

Webrevs

Copy link
Contributor

@TejeshR13 TejeshR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Except some minor updates.

@TejeshR13
Copy link
Contributor

  1. Update Copywrite year.
  2. Expand the imports.
  3. Jtreg test format.
  4. Frame title to be update w.r.t test purpose.

Copy link
Member

@aivanov-jdk aivanov-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@alisenchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed."

Reviewed-by: tr, aivanov, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 466 new commits pushed to the master branch:

  • c342188: 8328074: Add jcheck whitespace checking for assembly files
  • 3c70f26: 8328112: Remove CardTable::_guard_region
  • 48717d6: 8326333: jshell completion on arrays is incomplete
  • ece4124: 8328247: Remove redundant dir for tests converted from applet to main
  • d32ce65: 8327651: Rename DictionaryEntry members related to protection domain
  • 0719419: 8328236: module_entry in CDS map file has stale value
  • 0204aac: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
  • 9bc1b06: 8328242: Add a log area to the PassFailJFrame
  • 65a84c2: 8328006: refactor large anonymous inner class in HtmlDocletWriter
  • 044f4ed: 8326979: (jdeps) improve the error message for FindException caused by InvalidModuleDescriptorException
  • ... and 456 more: https://git.openjdk.org/jdk/compare/16b3be0a76b0a71c8f59168dfc94c06d8a899bd4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 11, 2024
@alisenchung
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 18, 2024

Going to push as commit 3f2e849.
Since your change was applied there have been 478 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 18, 2024
@openjdk openjdk bot closed this Mar 18, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 18, 2024
@openjdk
Copy link

openjdk bot commented Mar 18, 2024

@alisenchung Pushed as commit 3f2e849.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants