8327261: Parsing test for Double/Float succeeds w/o testing all bad cases #18113

naotoj · 2024-03-05T00:51:33Z

Fixing test cases. For bad test cases, only the first case was run, and the rest were ignored.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8327261: Parsing test for Double/Float succeeds w/o testing all bad cases (Bug - P4)

Reviewers

Joe Darcy (@jddarcy - Reviewer) ⚠️ Review applies to 4c80fe5c
Guoxiong Li (@lgxbslgx - Committer) ⚠️ Review applies to 4c80fe5c
Joe Wang (@JoeWang-Java - Reviewer)
Justin Lu (@justin-curtis-lu - Committer)
Brian Burkhalter (@bplb - Reviewer)
Lance Andersen (@LanceAndersen - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18113/head:pull/18113
$ git checkout pull/18113

Update a local copy of the PR:
$ git checkout pull/18113
$ git pull https://git.openjdk.org/jdk.git pull/18113/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18113

View PR using the GUI difftool:
$ git pr show -t 18113

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18113.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-03-05T00:52:00Z

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-03-05T00:53:24Z

@naotoj The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-03-05T00:57:07Z

Webrevs

01: Full - Incremental (c67ecc32)
00: Full (4c80fe5c)

jddarcy

Looks fine; thanks for sending out the fix.

openjdk · 2024-03-05T02:26:25Z

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327261: Parsing test for Double/Float succeeds w/o testing all bad cases

Reviewed-by: darcy, gli, joehw, jlu, bpb, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

c6641c7: 8326831: Clarify test harness control variables in make help
3d106cb: 8325139: JFR SwapSpace event - add free swap space information on Linux when running in a container environment
c00c939: 8327364: Parallel: Remove unused ParallelCompactData::add_obj
98f0b86: 8319690: [AArch64] C2 compilation hits offset_ok_for_immed: assert "c2 compiler bug"
2372aba: 8326172: Dubious claim on long[]/double[] alignment in MemorySegment javadoc
c653e67: 8327225: Revert DataInputStream.readUTF to static final
a089ed2: 8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations
560cf59: 8327287: Remove unused FLSVerifyDictionary debug option
fec51d4: 8327130: Serial: Remove Generation::record_spaces_top
e9adceb: 8327208: Remove unused method java.util.jar.Manifest.make72Safe
... and 5 more: https://git.openjdk.org/jdk/compare/045eea11307f5df89071c7c7e366effdc23a22db...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

jddarcy · 2024-03-05T02:26:55Z

test/jdk/java/lang/Double/ParseDouble.java

@@ -557,10 +557,8 @@ private static void rudimentaryTest() {
    private static void testParsing(String [] input,
                                    boolean exceptionalInput) {
        for(int i = 0; i < input.length; i++) {


As you're updating the file, I think changing the loop to an enhanced for loop would be an improvement.

lgxbslgx

Looks good.

Only a trivial suggestion.

lgxbslgx · 2024-03-05T14:16:26Z

test/jdk/java/lang/Double/ParseDouble.java

            try {
-                d = Double.parseDouble(input[i]);
+                Double.parseDouble(input[i]);
                check(input[i]);
            }
            catch (NumberFormatException e) {


The catch clause doesn't need to stay in a new line.

lgxbslgx · 2024-03-05T14:17:07Z

test/jdk/java/lang/Float/ParseFloat.java

            try {
-                d = Float.parseFloat(input[i]);
+                Float.parseFloat(input[i]);
                check(input[i]);
            }
            catch (NumberFormatException e) {


The catch clause doesn't need to stay in a new line.

naotoj · 2024-03-05T17:22:53Z

Thanks for the reviews. Updated as suggested

bplb

+1

naotoj · 2024-03-06T16:14:36Z

Thanks for the reviews!
/integrate

openjdk · 2024-03-06T16:15:24Z

Going to push as commit 9f70940.
Since your change was applied there have been 30 commits pushed to the master branch:

08b03a3: 8327376: Parallel: Remove unimplemented methods in psParallelCompact.hpp
ae5e3fd: 8327365: Inline and remove GCStats
326c91e: 8327288: Obsolete unused ProcessDistributionStride product option
a7461de: 8325255: jdk.internal.util.ReferencedKeySet::add using wrong test
2bdd387: 8327286: Obsolete unused NUMAPageScanRate product option
992104d: 8327239: Obsolete unused GCLockerEdenExpansionPercent product option
fbb422e: 8327201: C2: Uninitialized VLoop::_pre_loop_end after JDK-8324890
7d53559: 8319932: [JVMCI] class unloading related tests can fail on libgraal
bee50cd: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes
96bfe61: 8326458: Menu mnemonics don't toggle in Windows LAF when F10 is pressed
... and 20 more: https://git.openjdk.org/jdk/compare/045eea11307f5df89071c7c7e366effdc23a22db...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-03-06T16:15:30Z

@naotoj Pushed as commit 9f70940.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

initial commit

4c80fe5

openjdk bot added the rfr Pull request is ready for review label Mar 5, 2024

openjdk bot added the core-libs core-libs-dev@openjdk.org label Mar 5, 2024

jddarcy approved these changes Mar 5, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 5, 2024

jddarcy reviewed Mar 5, 2024

View reviewed changes

lgxbslgx approved these changes Mar 5, 2024

View reviewed changes

Reflects review comments

c67ecc3

JoeWang-Java approved these changes Mar 5, 2024

View reviewed changes

justin-curtis-lu approved these changes Mar 5, 2024

View reviewed changes

bplb approved these changes Mar 5, 2024

View reviewed changes

LanceAndersen approved these changes Mar 5, 2024

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Mar 6, 2024

openjdk bot closed this Mar 6, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8327261: Parsing test for Double/Float succeeds w/o testing all bad cases #18113

8327261: Parsing test for Double/Float succeeds w/o testing all bad cases #18113

naotoj commented Mar 5, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Mar 5, 2024

openjdk bot commented Mar 5, 2024

mlbridge bot commented Mar 5, 2024 •

edited

Loading

jddarcy left a comment

openjdk bot commented Mar 5, 2024 •

edited

Loading

jddarcy Mar 5, 2024

lgxbslgx left a comment

lgxbslgx Mar 5, 2024

lgxbslgx Mar 5, 2024

naotoj commented Mar 5, 2024

bplb left a comment

naotoj commented Mar 6, 2024

openjdk bot commented Mar 6, 2024

openjdk bot commented Mar 6, 2024

8327261: Parsing test for Double/Float succeeds w/o testing all bad cases #18113

8327261: Parsing test for Double/Float succeeds w/o testing all bad cases #18113

Conversation

naotoj commented Mar 5, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Mar 5, 2024

openjdk bot commented Mar 5, 2024

mlbridge bot commented Mar 5, 2024 • edited Loading

Webrevs

jddarcy left a comment

Choose a reason for hiding this comment

openjdk bot commented Mar 5, 2024 • edited Loading

jddarcy Mar 5, 2024

Choose a reason for hiding this comment

lgxbslgx left a comment

Choose a reason for hiding this comment

lgxbslgx Mar 5, 2024

Choose a reason for hiding this comment

lgxbslgx Mar 5, 2024

Choose a reason for hiding this comment

naotoj commented Mar 5, 2024

bplb left a comment

Choose a reason for hiding this comment

naotoj commented Mar 6, 2024

openjdk bot commented Mar 6, 2024

openjdk bot commented Mar 6, 2024

naotoj commented Mar 5, 2024 •

edited by openjdk bot

Loading

mlbridge bot commented Mar 5, 2024 •

edited

Loading

openjdk bot commented Mar 5, 2024 •

edited

Loading