8327287: Remove unused FLSVerifyDictionary debug option

[tschatzl]

Hi all,

please review this removal of some CMS specific verification debug option.

Testing: local compilation, grepping through sources

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8327287: Remove unused FLSVerifyDictionary debug option (Enhancement - P4)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Kim Barrett (@kimbarrett - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18116/head:pull/18116
$ git checkout pull/18116

Update a local copy of the PR:
$ git checkout pull/18116
$ git pull https://git.openjdk.org/jdk.git pull/18116/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18116

View PR using the GUI difftool:
$ git pr show -t 18116

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18116.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f1864355)

[tschatzl]

/label add hotspot-gc
/label remove hotspot-runtime
(It's a CMS collector option)

[openjdk]

@tschatzl
The hotspot-gc label was successfully added.

[openjdk]

@tschatzl
The hotspot-runtime label was successfully removed.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327287: Remove unused FLSVerifyDictionary debug option

Reviewed-by: ayang, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• fec51d4: 8327130: Serial: Remove Generation::record_spaces_top
• e9adceb: 8327208: Remove unused method java.util.jar.Manifest.make72Safe

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kimbarrett]

Looks good, and trivial.

[tschatzl]

Thanks @albertnetymk @kimbarrett for your reviews
/integrate

[openjdk]

Going to push as commit 560cf59.
Since your change was applied there have been 2 commits pushed to the master branch:

• fec51d4: 8327130: Serial: Remove Generation::record_spaces_top
• e9adceb: 8327208: Remove unused method java.util.jar.Manifest.make72Safe

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 560cf59.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.