Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8327286: Obsolete unused NUMAPageScanRate product option #18118

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Mar 5, 2024

Hi all,

please review making the flag NUMAPageScanRate obsolete.

This option controlled some fairly esoteric performance capability for Solaris; Solaris support has been removed in JDK 15, and the last remaining reference to the option (which was a no-op) in JDK 22.

Please also look at the CSR.

Testing: local compilation, grepping sources, starting the VM with that option to see that the message shows up.

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8327338 to be approved

Issues

  • JDK-8327286: Obsolete unused NUMAPageScanRate product option (Enhancement - P4)
  • JDK-8327338: Obsolete unused NUMAPageScanRate product option (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18118/head:pull/18118
$ git checkout pull/18118

Update a local copy of the PR:
$ git checkout pull/18118
$ git pull https://git.openjdk.org/jdk.git pull/18118/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18118

View PR using the GUI difftool:
$ git pr show -t 18118

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18118.diff

Webrev

Link to Webrev Comment

Thomas Schatzl added 2 commits March 5, 2024 10:35
Hi all,

  please review this change to obsolete the unused flag GCLockerEdenExpansionPercent. Please also review the CSR.

Testing: local compilation, grepping sources for occurrences

Thanks,
  Thomas
Hi all,

  please review making the flag `NUMAPageScanRate` obsolete.

This option controlled some fairly esoteric performance capability for Solaris; Solaris support has been removed in JDK 15, and the last remaining reference to the option (which was a no-op) in JDK 22.

Testing: local compilation, grepping sources, starting the VM with that option to see that the message shows up.

Thanks,
  Thomas
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 5, 2024

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into pr/18117 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8327286 8327286: Obsolete unused NUMAPageScanRate product option Mar 5, 2024
@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Mar 5, 2024
@openjdk
Copy link

openjdk bot commented Mar 5, 2024

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Mar 5, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 5, 2024

Webrevs

@tschatzl
Copy link
Contributor Author

tschatzl commented Mar 5, 2024

/label add hotspot-gc

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Mar 5, 2024
@openjdk
Copy link

openjdk bot commented Mar 5, 2024

@tschatzl
The hotspot-gc label was successfully added.

Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Mar 5, 2024
@openjdk-notifier openjdk-notifier bot changed the base branch from pr/18117 to master March 6, 2024 11:38
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout submit/8327286-obsolete-NUMAPageScanRate
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Mar 6, 2024

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327286: Obsolete unused NUMAPageScanRate product option

Reviewed-by: kbarrett, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 6, 2024
@tschatzl
Copy link
Contributor Author

tschatzl commented Mar 6, 2024

Thanks @albertnetymk @kimbarrett for your reviews
/integrate

@openjdk
Copy link

openjdk bot commented Mar 6, 2024

Going to push as commit 2bdd387.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 6, 2024
@openjdk openjdk bot closed this Mar 6, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 6, 2024
@openjdk
Copy link

openjdk bot commented Mar 6, 2024

@tschatzl Pushed as commit 2bdd387.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8327286-obsolete-NUMAPageScanRate branch June 11, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants