8327288: Obsolete unused ProcessDistributionStride product option

[tschatzl]

Hi all,

please review the obsoletion of the unused ProcessDistributionStride option. It controlled how threads were distributed across "boards" on Solaris. Solaris support has been removed in JDK 15, so this option is not needed/used either.

Testing: local compilation, grepping sources, testing the option to give the expected warning message

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change requires CSR request JDK-8327358 to be approved
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8327288: Obsolete unused ProcessDistributionStride product option (Enhancement - P4)
• JDK-8327358: Obsolete unused ProcessDistributionStride product option (CSR)

Reviewers

• Kim Barrett (@kimbarrett - Reviewer) ⚠️ Review applies to 978e5ff3
• Albert Mingkun Yang (@albertnetymk - Reviewer) ⚠️ Review applies to 978e5ff3

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18119/head:pull/18119
$ git checkout pull/18119

Update a local copy of the PR:
$ git checkout pull/18119
$ git pull https://git.openjdk.org/jdk.git pull/18119/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18119

View PR using the GUI difftool:
$ git pr show -t 18119

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18119.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into pr/18118 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full (666bc41f)
• 00: Full (978e5ff3)

[tschatzl]

/label add hotspot-gc

[openjdk]

@tschatzl
The hotspot-gc label was successfully added.

[kimbarrett]

Looks good.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout submit/8327288-obsolete-processdistributionstride
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@tschatzl this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout submit/8327288-obsolete-processdistributionstride
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327288: Obsolete unused ProcessDistributionStride product option

Reviewed-by: kbarrett, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Thanks @albertnetymk @kimbarrett for your reviews
/integrate

[openjdk]

Going to push as commit 326c91e.
Since your change was applied there has been 1 commit pushed to the master branch:

• a7461de: 8325255: jdk.internal.util.ReferencedKeySet::add using wrong test

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 326c91e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.