Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8327365: Inline and remove GCStats #18122

Closed
wants to merge 5 commits into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Mar 5, 2024

Simple refactoring to move a field from superclass to subclass.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8327365: Inline and remove GCStats (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18122/head:pull/18122
$ git checkout pull/18122

Update a local copy of the PR:
$ git checkout pull/18122
$ git pull https://git.openjdk.org/jdk.git pull/18122/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18122

View PR using the GUI difftool:
$ git pr show -t 18122

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18122.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 5, 2024

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8327365 8327365: Serial: Move _gc_stats to TenuredGeneration Mar 5, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 5, 2024
@openjdk
Copy link

openjdk bot commented Mar 5, 2024

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Mar 5, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 5, 2024

Webrevs

// decide what statistics are valid to collect. For example, the
// generation can decide to gather the amount of promoted data if
// the collection of the young generation has completed.
GCStats* gc_stats() const { return _gc_stats; }
virtual void update_gc_stats(Generation* current_generation, bool full) {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method update_gc_stats here can be removed and the method update_gc_stats in tenuredGeneration.hpp can be non-virtual.

Copy link
Member

@lgxbslgx lgxbslgx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tschatzl
Copy link
Contributor

tschatzl commented Mar 6, 2024

There is no more GCStats use in serial gc, all references to it in generation.hpp and tenuredGeneration.hpp can be removed (forward decl, include).
Also GCStats files can be moved to the parallel directory.

Tbh, similar to serial gc, GCStats could be replaced by the AdaptivePaddedNoZeroDevAverage class in Parallel GC too and completely removed. I.e. imo either both or none of these replacements should be done.

@albertnetymk
Copy link
Member Author

I think GCStats can be inlined in Parallel as well. That is independent of this PR (Serial-only), so I left it out here.

@albertnetymk albertnetymk changed the title 8327365: Serial: Move _gc_stats to TenuredGeneration 8327365 Mar 6, 2024
@albertnetymk
Copy link
Member Author

Included both Serial and Parallel in the latest revision.

@openjdk openjdk bot changed the title 8327365 8327365: Inline and remove GCStats Mar 6, 2024
Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

_avg_promoted does not need to be a reference I think, but that can be changed separately potentially together with the other statistics.

@openjdk
Copy link

openjdk bot commented Mar 6, 2024

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327365: Inline and remove GCStats

Reviewed-by: gli, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • a7461de: 8325255: jdk.internal.util.ReferencedKeySet::add using wrong test
  • 2bdd387: 8327286: Obsolete unused NUMAPageScanRate product option
  • 992104d: 8327239: Obsolete unused GCLockerEdenExpansionPercent product option

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 6, 2024
@albertnetymk
Copy link
Member Author

Thanks for review.

/integrate

@openjdk
Copy link

openjdk bot commented Mar 6, 2024

Going to push as commit ae5e3fd.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 326c91e: 8327288: Obsolete unused ProcessDistributionStride product option
  • a7461de: 8325255: jdk.internal.util.ReferencedKeySet::add using wrong test
  • 2bdd387: 8327286: Obsolete unused NUMAPageScanRate product option
  • 992104d: 8327239: Obsolete unused GCLockerEdenExpansionPercent product option

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 6, 2024
@openjdk openjdk bot closed this Mar 6, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 6, 2024
@openjdk
Copy link

openjdk bot commented Mar 6, 2024

@albertnetymk Pushed as commit ae5e3fd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the s1-flatten-gc-stat branch March 6, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants