Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8327390: JitTester: Implement temporary folder functionality #18128

Closed

Conversation

lepestock
Copy link
Contributor

@lepestock lepestock commented Mar 5, 2024

The JITTester relies on standard OS / Java library functionality to create temporary folders and never cleans them.

This creates problems in CI machines and also complicates problems investigation. We need to have a dedicated TempDir entity that we could adjust during problems investigations and development. It can also be a good place for various file-related activities, like executing FailureHandler.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8327390: JitTester: Implement temporary folder functionality (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18128/head:pull/18128
$ git checkout pull/18128

Update a local copy of the PR:
$ git checkout pull/18128
$ git pull https://git.openjdk.org/jdk.git pull/18128/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18128

View PR using the GUI difftool:
$ git pr show -t 18128

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18128.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 5, 2024

👋 Welcome back enikitin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 5, 2024

@lepestock The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Mar 5, 2024
Copy link
Member

@lgxbslgx lgxbslgx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. And the issue is not a public visible issue, . Please mark the issue as non-secret.

@lepestock
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@lepestock This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327390: JitTester: Implement temporary folder functionality

Reviewed-by: gli, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 233 new commits pushed to the master branch:

  • d7273ac: 8320646: RISC-V: C2 VectorCastHF2F
  • 53c4714: 8327501: Common ForkJoinPool prevents class unloading in some cases
  • 1261740: 8327283: RISC-V: Minimal build failed after JDK-8319716
  • f54e598: 8327172: C2 SuperWord: data node in loop has no input in loop: replace assert with bailout
  • 4018341: 8327379: Make TimeLinearScan a develop flag
  • 1bd4abf: 8327434: Test java/util/PluggableLocale/TimeZoneNameProviderTest.java timed out
  • ddcd6de: 8325532: serviceability/dcmd/compiler/PerfMapTest.java leaves created files in the /tmp dir.
  • 3d37b28: 8327173: HotSpot Style Guide needs update regarding nullptr vs NULL
  • 989fc3e: 8325878: Require minimum Clang version 13
  • 13c7453: 8325880: Require minimum Open XL C/C++ version 17.1.1
  • ... and 223 more: https://git.openjdk.org/jdk/compare/f3073db42aa80b3ced47edea8d2e8add874fb70f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@lgxbslgx, @lmesnik) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 7, 2024
@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@lepestock
Your change (at version 4889902) is now ready to be sponsored by a Committer.

@mlbridge
Copy link

mlbridge bot commented Mar 7, 2024

Webrevs

@lmesnik
Copy link
Member

lmesnik commented Mar 7, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 7, 2024

Going to push as commit 5aae803.
Since your change was applied there have been 234 commits pushed to the master branch:

  • 784f11c: 8327238: Remove MetadataAllocationFailALot* develop flags
  • d7273ac: 8320646: RISC-V: C2 VectorCastHF2F
  • 53c4714: 8327501: Common ForkJoinPool prevents class unloading in some cases
  • 1261740: 8327283: RISC-V: Minimal build failed after JDK-8319716
  • f54e598: 8327172: C2 SuperWord: data node in loop has no input in loop: replace assert with bailout
  • 4018341: 8327379: Make TimeLinearScan a develop flag
  • 1bd4abf: 8327434: Test java/util/PluggableLocale/TimeZoneNameProviderTest.java timed out
  • ddcd6de: 8325532: serviceability/dcmd/compiler/PerfMapTest.java leaves created files in the /tmp dir.
  • 3d37b28: 8327173: HotSpot Style Guide needs update regarding nullptr vs NULL
  • 989fc3e: 8325878: Require minimum Clang version 13
  • ... and 224 more: https://git.openjdk.org/jdk/compare/f3073db42aa80b3ced47edea8d2e8add874fb70f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 7, 2024
@openjdk openjdk bot closed this Mar 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 7, 2024
@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@lmesnik @lepestock Pushed as commit 5aae803.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants