8327238: Remove MetadataAllocationFailALot* develop flags

[tschatzl]

Hi all,

please review this trivial removal of the MetadataFailAlot flags; one of them,
MetadataAllocationFailALotInterval is unused anyway, and the other MetadataAllocationFailALot only prevents the attempt to retry metadata allocation in the VM operation.

This functionality does not seem to stress metadata allocation failure at all, just execution of the metadata VM operation, so I decided to just drop the second flag as well.

I considered keeping it maybe as MetadataAllocationFailRetry or something, but decided against it since it does not seem interesting to test. However I can at reviewer's request do that.

Testing: local compilation, gha, grepping hotspot tests/hotspot sources

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8327238: Remove MetadataAllocationFailALot* develop flags (Enhancement - P4)

Reviewers

• Guoxiong Li (@lgxbslgx - Committer)
• Albert Mingkun Yang (@albertnetymk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18133/head:pull/18133
$ git checkout pull/18133

Update a local copy of the PR:
$ git checkout pull/18133
$ git pull https://git.openjdk.org/jdk.git pull/18133/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18133

View PR using the GUI difftool:
$ git pr show -t 18133

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18133.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c6534a73)

[lgxbslgx]

LGTM.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327238: Remove MetadataAllocationFailALot* develop flags

Reviewed-by: gli, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• d7273ac: 8320646: RISC-V: C2 VectorCastHF2F
• 53c4714: 8327501: Common ForkJoinPool prevents class unloading in some cases
• 1261740: 8327283: RISC-V: Minimal build failed after JDK-8319716
• f54e598: 8327172: C2 SuperWord: data node in loop has no input in loop: replace assert with bailout
• 4018341: 8327379: Make TimeLinearScan a develop flag
• 1bd4abf: 8327434: Test java/util/PluggableLocale/TimeZoneNameProviderTest.java timed out
• ddcd6de: 8325532: serviceability/dcmd/compiler/PerfMapTest.java leaves created files in the /tmp dir.
• 3d37b28: 8327173: HotSpot Style Guide needs update regarding nullptr vs NULL
• 989fc3e: 8325878: Require minimum Clang version 13
• 13c7453: 8325880: Require minimum Open XL C/C++ version 17.1.1
• ... and 11 more: https://git.openjdk.org/jdk/compare/bee50cd330c9f31bf8830caf87f97cd72e7adc95...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Thanks @lgxbslgx @albertnetymk for your reviews
/integrate

[openjdk]

Going to push as commit 784f11c.
Since your change was applied there have been 21 commits pushed to the master branch:

• d7273ac: 8320646: RISC-V: C2 VectorCastHF2F
• 53c4714: 8327501: Common ForkJoinPool prevents class unloading in some cases
• 1261740: 8327283: RISC-V: Minimal build failed after JDK-8319716
• f54e598: 8327172: C2 SuperWord: data node in loop has no input in loop: replace assert with bailout
• 4018341: 8327379: Make TimeLinearScan a develop flag
• 1bd4abf: 8327434: Test java/util/PluggableLocale/TimeZoneNameProviderTest.java timed out
• ddcd6de: 8325532: serviceability/dcmd/compiler/PerfMapTest.java leaves created files in the /tmp dir.
• 3d37b28: 8327173: HotSpot Style Guide needs update regarding nullptr vs NULL
• 989fc3e: 8325878: Require minimum Clang version 13
• 13c7453: 8325880: Require minimum Open XL C/C++ version 17.1.1
• ... and 11 more: https://git.openjdk.org/jdk/compare/bee50cd330c9f31bf8830caf87f97cd72e7adc95...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 784f11c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.