8327477: Parallel: Remove _data_location and _highest_ref in ParallelCompactData

[albertnetymk]

Trivial removing dead code.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8327477: Parallel: Remove _data_location and _highest_ref in ParallelCompactData (Enhancement - P4)

Reviewers

• Guoxiong Li (@lgxbslgx - Committer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18139/head:pull/18139
$ git checkout pull/18139

Update a local copy of the PR:
$ git checkout pull/18139
$ git pull https://git.openjdk.org/jdk.git pull/18139/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18139

View PR using the GUI difftool:
$ git pr show -t 18139

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18139.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (b48d61b8)
• 00: Full (e7b5fab1)

[lgxbslgx]

Looks like a leftover of JDK-8323518. One nit.

[lgxbslgx]

Now, we only have one field here. So the word These in the comment should be revised to This? Or the comment needs more adjustment.

[albertnetymk]

Actually, _data_location is used only for printing, and it records the corresponding heap-addr of a region, if I read the code correctly. How about removing _data_location as well, given its limited value?

[lgxbslgx]

it records the corresponding heap-addr of a region, if I read the code correctly.

I searched the code and think you are right. It is good to remove _data_location.

[openjdk]

@albertnetymk Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[lgxbslgx]

Looks good.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327477: Parallel: Remove _data_location and _highest_ref in ParallelCompactData

Reviewed-by: gli, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• bdd1aeb: 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection
• fb4610e: 8327444: simplify RESTARTABLE macro usage in JDK codebase
• de428da: 8327426: RISC-V: Move alignment shim into initialize_header() in C1_MacroAssembler::allocate_array
• 8dbd4b3: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate
• 7c5e6e7: 8327147: Improve performance of Math ceil, floor, and rint for x86
• 972e81d: 8326611: Clean up vmTestbase/nsk/stress/stack tests
• 5aae803: 8327390: JitTester: Implement temporary folder functionality
• 784f11c: 8327238: Remove MetadataAllocationFailALot* develop flags

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[albertnetymk]

Thanks for review.

/integrate

[openjdk]

Going to push as commit f9d479f.
Since your change was applied there have been 8 commits pushed to the master branch:

• bdd1aeb: 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection
• fb4610e: 8327444: simplify RESTARTABLE macro usage in JDK codebase
• de428da: 8327426: RISC-V: Move alignment shim into initialize_header() in C1_MacroAssembler::allocate_array
• 8dbd4b3: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate
• 7c5e6e7: 8327147: Improve performance of Math ceil, floor, and rint for x86
• 972e81d: 8326611: Clean up vmTestbase/nsk/stress/stack tests
• 5aae803: 8327390: JitTester: Implement temporary folder functionality
• 784f11c: 8327238: Remove MetadataAllocationFailALot* develop flags

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit f9d479f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.