JDK-8327487: Further augment WorstCaseTests with more cases

[jddarcy]

The atan2 and hypot cases added would fail for a particular test library that has errors in the millions of ulps for those inputs, rather than the small number of ulps specified for the error.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8327487: Further augment WorstCaseTests with more cases (Enhancement - P4)

Reviewers

• Raffaello Giulietti (@rgiulietti - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18140/head:pull/18140
$ git checkout pull/18140

Update a local copy of the PR:
$ git checkout pull/18140
$ git pull https://git.openjdk.org/jdk.git pull/18140/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18140

View PR using the GUI difftool:
$ git pr show -t 18140

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18140.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jddarcy The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (67df3748)
• 01: Full - Incremental (6b2d7870)
• 00: Full (3aba735c)

[rgiulietti]

Looks good

[rgiulietti]

Suggested change

	double ulps = 3.0;
	double ulps = 3.0; // 1.5 + 1.0, rounded up

[turbanoff]

Suggested change

	for(double[] testCase: testCases) {
	for (double[] testCase: testCases) {

[openjdk]

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327487: Further augment WorstCaseTests with more cases

Reviewed-by: rgiulietti

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 76 new commits pushed to the master branch:

• 78beb03: 8327750: Convert javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java applet test to main
• 1f43fa0: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS
• 013aff8: 8326606: Test javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on a value based class
• b92440f: 8247972: incorrect implementation of JVM TI GetObjectMonitorUsage
• 139681a: 8326497: Window.toFront() fails for iconified windows on Linux
• 9f7aff4: 8327788: G1: Improve concurrent reference processing documentation
• 251347b: 8326139: C2 SuperWord: split packs (match use/def packs, implemented, mutual independence)
• e21da4c: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269
• 4d6235e: 8327716: RISC-V: Change type of vector_length param of several assembler functions from int to uint
• 586396c: 8327705: Remove mention of "applet" from java.text package description
• ... and 66 more: https://git.openjdk.org/jdk/compare/809995b526ea79e4fd9fd4f911bcce811f77eb89...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[turbanoff]

nit

Suggested change

	for(double[] testCase: testCases) {
	for (double[] testCase: testCases) {

[jddarcy]

/integrate

[openjdk]

Going to push as commit 201042f.
Since your change was applied there have been 82 commits pushed to the master branch:

• 379ad1f: 8312444: Delete unused parameters and variables in SocketPermission
• 782206b: 8327748: Convert javax/swing/JFileChooser/6798062/bug6798062.java applet test to main
• 0776fff: 8327794: RISC-V: enable extension features based on impid (Rivos specific change)
• cfd9209: 8327751: Convert javax/swing/JInternalFrame/6726866/bug6726866.java applet test to main
• 2cf3524: 8325433: Type annotations on primitive types are not linked
• 5056902: 8327361: Update some comments after JDK-8139457
• 78beb03: 8327750: Convert javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java applet test to main
• 1f43fa0: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS
• 013aff8: 8326606: Test javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on a value based class
• b92440f: 8247972: incorrect implementation of JVM TI GetObjectMonitorUsage
• ... and 72 more: https://git.openjdk.org/jdk/compare/809995b526ea79e4fd9fd4f911bcce811f77eb89...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jddarcy Pushed as commit 201042f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.