8327476: Upgrade JLine to 3.26.1

[lahodaj]

This is a patch that:
a) upgrades the JLine inside the JDK to 3.25.1
b) since the new version of JLine has a FFM backend, our custom native backends are removed, and replaced with the FFM backend

Some changes had to be made to the original JLine in order to fit into the JDK. Most of them were already done for the previous version (repackaging, avoiding non-ASCII characters, commenting out logging, adding ability to modify to wrap the InputStream used by the terminal), and have only been transferred to the new one. The main two new changes are:

• fixes to the FFM backend, so that it works on Linux and JDK 22. These have been proposed to JLine itself: Fixing the FfmTerminal to run on JDK 22 and on Linux. jline/jline3#945
• disabling the NativeFileDescriptorCreator, as I believe we don't need it, and cannot make it work easily

There's a full patch between the src/jdk.internal.le/share/classes/jdk/internal/org and the merged content of the corresponding sources of these original JLine sub-projects:
https://github.com/jline/jline3/tree/jline-parent-3.25.1/reader
https://github.com/jline/jline3/tree/jline-parent-3.25.1/terminal-ffm
https://github.com/jline/jline3/tree/jline-parent-3.25.1/terminal
the patch is here:
https://cr.openjdk.org/~jlahoda/8327476/jline-3.25.1-upgrade.diff

I've also cleaned the patch a little removing most of the changes for the rename. The result is here:
https://cr.openjdk.org/~jlahoda/8327476/jline-3.25.1-upgrade-significant.diff

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8327476: Upgrade JLine to 3.26.1 (Task - P4)

Reviewers

• Magnus Ihse Bursie (@magicus - Reviewer) ⚠️ Review applies to 9f6509a9
• Vicente Romero (@vicente-romero-oracle - Reviewer) ⚠️ Review applies to c8097592

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18142/head:pull/18142
$ git checkout pull/18142

Update a local copy of the PR:
$ git checkout pull/18142
$ git pull https://git.openjdk.org/jdk.git pull/18142/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18142

View PR using the GUI difftool:
$ git pr show -t 18142

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18142.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into pr/18106 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj The following labels will be automatically applied to this pull request:

• build
• kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 06: Full (5d900a6e)
• 05: Full - Incremental (9f6509a9)
• 04: Full (01f95c42)
• 03: Full (c8097592)
• 02: Full (fe8d5a42)
• 01: Full (d6c2072f)
• 00: Full (d6c2072f)

[magicus]

I'm just curious: How did you arrive at these values? They seem like they are generated somehow. (I guess you did not just make them up and write them down here). Can that process be documented? Or saved as a script in case they ever need to be updated?

[magicus]

For consistency:

Suggested change

	System.loadLibrary("Kernel32");
	System.loadLibrary("kernel32");

[magicus]

Here is another bunch of constants that seem generated. Is this file created by jextract? (I'm sorry, I have not played around enough with jextract to recognize the output it generates).

In any way, some documentation on how this file was created, if any kind of automation was involved, would be nice.

[magicus]

Aha, now I understand! The new files in jdk.internal.org.jline.terminal.impl.ffm comes from upstream. I thought they were additions made by you.

I guess that means my comments are still valid, but should be asked upstream instead. And that you don't need to address them here.

[lahodaj]

Update: since JLine 3.26.1 was release, I tried to upgrade to that directly. I made a diff of the relevant files between JLine 3.25.1 and 3.26.1, and applied that diff to our code. Some additional cleanup was done as well, as suggested by Magnus.

[lahodaj]

/integrate

[openjdk]

Going to push as commit aaa90b3.
Since your change was applied there have been 30 commits pushed to the master branch:

• 0a4eeea: 8331033: EA fails with "EA unexpected CallLeaf unsafe_setmemory" after JDK-8329331
• ad0b54d: 8314225: SIGSEGV in JavaThread::is_lock_owned
• ac86f59: 8330532: Improve line-oriented text parsing in HotSpot
• 964d608: 8322753: RISC-V: C2 ReverseBytesV
• 2d62215: 8331541: [i386] linking with libjvm.so fails after JDK-8283326
• 588e314: 8331886: Allow markdown src file overrides
• 0d1216c: 8331939: Add custom hook for TestImage
• 42b1d85: 8330275: Crash in XMark::follow_array
• 230fac8: 8331941: Make CollectedHeap::parallel_object_iterator public
• c845261: 8331924: Parallel: Remove unused MutableSpace::mangle_unused_area_complete
• ... and 20 more: https://git.openjdk.org/jdk/compare/23a72a1f2f651d5e8e9a0eb1e75e2b44572a13da...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj Pushed as commit aaa90b3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.