-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8327501: Common ForkJoinPool prevents class unloading in some cases #18144
Conversation
creating threads in the common ForkJoinPool preventing class unloading. This fix avoids that when no SecurityManager is configured.
👋 Welcome back vklang! A progress list of the required criteria for merging this PR into |
@viktorklang-ora The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Adding @DougLea and @AlanBateman for comments. |
Yes, this seems like the simplest practical solution. |
The inherited access control context bites again. Creating a Thread takes a snapshot of the caller context which can include several protection domains. In the bug report it includes a ProtectionDomain for a custom class loader. The good news is that removal of the security manager mode of execution means that this can go away. |
@viktorklang-ora This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 49 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 53c4714.
Your commit was automatically rebased without conflicts. |
@viktorklang-ora Pushed as commit 53c4714. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi @trancexpress, thanks for making a comment in an OpenJDK project! All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user trancexpress" for the summary. If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.
Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use. |
@trancexpress I defer all credit to @AlanBateman. :) |
The common ForkJoinPool creating threads as a result of submitting tasks is preventing class unloading when the thread construction is initiated from a class loaded in a separate classloader. This fix avoids that when no SecurityManager is configured.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18144/head:pull/18144
$ git checkout pull/18144
Update a local copy of the PR:
$ git checkout pull/18144
$ git pull https://git.openjdk.org/jdk.git pull/18144/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18144
View PR using the GUI difftool:
$ git pr show -t 18144
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18144.diff
Webrev
Link to Webrev Comment