Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8327501: Common ForkJoinPool prevents class unloading in some cases #18144

Closed
wants to merge 1 commit into from

Conversation

viktorklang-ora
Copy link
Contributor

@viktorklang-ora viktorklang-ora commented Mar 6, 2024

The common ForkJoinPool creating threads as a result of submitting tasks is preventing class unloading when the thread construction is initiated from a class loaded in a separate classloader. This fix avoids that when no SecurityManager is configured.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8327501: Common ForkJoinPool prevents class unloading in some cases (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18144/head:pull/18144
$ git checkout pull/18144

Update a local copy of the PR:
$ git checkout pull/18144
$ git pull https://git.openjdk.org/jdk.git pull/18144/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18144

View PR using the GUI difftool:
$ git pr show -t 18144

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18144.diff

Webrev

Link to Webrev Comment

creating threads in the common ForkJoinPool preventing
class unloading. This fix avoids that when no SecurityManager
is configured.
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 6, 2024

👋 Welcome back vklang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 6, 2024
@openjdk
Copy link

openjdk bot commented Mar 6, 2024

@viktorklang-ora The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Mar 6, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 6, 2024

Webrevs

@viktorklang-ora
Copy link
Contributor Author

Adding @DougLea and @AlanBateman for comments.

@DougLea
Copy link
Contributor

DougLea commented Mar 6, 2024

Yes, this seems like the simplest practical solution.

@AlanBateman
Copy link
Contributor

The inherited access control context bites again. Creating a Thread takes a snapshot of the caller context which can include several protection domains. In the bug report it includes a ProtectionDomain for a custom class loader. The good news is that removal of the security manager mode of execution means that this can go away.

@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@viktorklang-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327501: Common ForkJoinPool prevents class unloading in some cases

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

  • f54e598: 8327172: C2 SuperWord: data node in loop has no input in loop: replace assert with bailout
  • 4018341: 8327379: Make TimeLinearScan a develop flag
  • 1bd4abf: 8327434: Test java/util/PluggableLocale/TimeZoneNameProviderTest.java timed out
  • ddcd6de: 8325532: serviceability/dcmd/compiler/PerfMapTest.java leaves created files in the /tmp dir.
  • 3d37b28: 8327173: HotSpot Style Guide needs update regarding nullptr vs NULL
  • 989fc3e: 8325878: Require minimum Clang version 13
  • 13c7453: 8325880: Require minimum Open XL C/C++ version 17.1.1
  • 4f33608: 8326718: Test java/util/Formatter/Padding.java should timeout on large inputs before fix in JDK-8299677
  • e92ecd9: 8326983: Unused operands reported after JDK-8326135
  • 9f70940: 8327261: Parsing test for Double/Float succeeds w/o testing all bad cases
  • ... and 39 more: https://git.openjdk.org/jdk/compare/e889b460c03b3887ec5477fa734c430d3c3a41c8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 7, 2024
@viktorklang-ora
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 7, 2024

Going to push as commit 53c4714.
Since your change was applied there have been 50 commits pushed to the master branch:

  • 1261740: 8327283: RISC-V: Minimal build failed after JDK-8319716
  • f54e598: 8327172: C2 SuperWord: data node in loop has no input in loop: replace assert with bailout
  • 4018341: 8327379: Make TimeLinearScan a develop flag
  • 1bd4abf: 8327434: Test java/util/PluggableLocale/TimeZoneNameProviderTest.java timed out
  • ddcd6de: 8325532: serviceability/dcmd/compiler/PerfMapTest.java leaves created files in the /tmp dir.
  • 3d37b28: 8327173: HotSpot Style Guide needs update regarding nullptr vs NULL
  • 989fc3e: 8325878: Require minimum Clang version 13
  • 13c7453: 8325880: Require minimum Open XL C/C++ version 17.1.1
  • 4f33608: 8326718: Test java/util/Formatter/Padding.java should timeout on large inputs before fix in JDK-8299677
  • e92ecd9: 8326983: Unused operands reported after JDK-8326135
  • ... and 40 more: https://git.openjdk.org/jdk/compare/e889b460c03b3887ec5477fa734c430d3c3a41c8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 7, 2024
@openjdk openjdk bot closed this Mar 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 7, 2024
@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@viktorklang-ora Pushed as commit 53c4714.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@trancexpress
Copy link

trancexpress commented Mar 7, 2024

Hi @trancexpress, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user trancexpress" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

@viktorklang-ora
Copy link
Contributor Author

@trancexpress I defer all credit to @AlanBateman. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants