Skip to content

8327522: Shenandoah: Remove unused references to satb_mark_queue_active_offset#18148

Closed
linade wants to merge 1 commit intoopenjdk:masterfrom
linade:JDK-8327522
Closed

8327522: Shenandoah: Remove unused references to satb_mark_queue_active_offset#18148
linade wants to merge 1 commit intoopenjdk:masterfrom
linade:JDK-8327522

Conversation

@linade
Copy link
Contributor

@linade linade commented Mar 7, 2024

Removed an unused variable (trivial)

Also, there is another place that uses satb_mark_queue_active_offset which is ShenandoahBarrierSetC2::verify_gc_barriers
The current barrier pattern is different from what this code is expecting:
If->Bool->CmpI->AndI->LoadUB->AddP->ConL(gc_state_offset)
rather than
If->Bool->CmpI->LoadB->AddP->ConL(marking_offset)
However, this code isn't doing as much checking as its counterpart in G1 anyway (so I'm thinking removing the incorrect matching code altogether?) Looking forward to your suggestions.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8327522: Shenandoah: Remove unused references to satb_mark_queue_active_offset (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18148/head:pull/18148
$ git checkout pull/18148

Update a local copy of the PR:
$ git checkout pull/18148
$ git pull https://git.openjdk.org/jdk.git pull/18148/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18148

View PR using the GUI difftool:
$ git pr show -t 18148

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18148.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 7, 2024

👋 Welcome back linade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 7, 2024
@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@linade The following labels will be automatically applied to this pull request:

  • hotspot
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot hotspot-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Mar 7, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 7, 2024

Webrevs

@linade
Copy link
Contributor Author

linade commented Mar 7, 2024

/label hotspot-gc

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Mar 7, 2024
@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@linade
The hotspot-gc label was successfully added.

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 11, 2024

@linade This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2024

@linade This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org hotspot-gc hotspot-gc-dev@openjdk.org rfr Pull request is ready for review shenandoah shenandoah-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant