8327522: Shenandoah: Remove unused references to satb_mark_queue_active_offset#18148
8327522: Shenandoah: Remove unused references to satb_mark_queue_active_offset#18148linade wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back linade! A progress list of the required criteria for merging this PR into |
|
/label hotspot-gc |
|
@linade |
|
❗ This change is not yet ready to be integrated. |
|
@linade This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
@linade This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
Removed an unused variable (trivial)
Also, there is another place that uses satb_mark_queue_active_offset which is ShenandoahBarrierSetC2::verify_gc_barriers
The current barrier pattern is different from what this code is expecting:
If->Bool->CmpI->AndI->LoadUB->AddP->ConL(gc_state_offset)
rather than
If->Bool->CmpI->LoadB->AddP->ConL(marking_offset)
However, this code isn't doing as much checking as its counterpart in G1 anyway (so I'm thinking removing the incorrect matching code altogether?) Looking forward to your suggestions.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18148/head:pull/18148$ git checkout pull/18148Update a local copy of the PR:
$ git checkout pull/18148$ git pull https://git.openjdk.org/jdk.git pull/18148/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18148View PR using the GUI difftool:
$ git pr show -t 18148Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18148.diff
Webrev
Link to Webrev Comment