Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8327631: Update IANA Language Subtag Registry to Version 2024-03-07 #18159

Conversation

justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented Mar 7, 2024

Please review this PR which is a trivial update to the IANA sub tag registry to version 2024-03-07. Tests pass as expected after update.

Associated announcement -> https://mm.icann.org/pipermail/ietf-languages-announcements/2024-March/000090.html


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8327631: Update IANA Language Subtag Registry to Version 2024-03-07 (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18159/head:pull/18159
$ git checkout pull/18159

Update a local copy of the PR:
$ git checkout pull/18159
$ git pull https://git.openjdk.org/jdk.git pull/18159/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18159

View PR using the GUI difftool:
$ git pr show -t 18159

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18159.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 7, 2024

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 7, 2024
@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@justin-curtis-lu The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Mar 7, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 7, 2024

Webrevs

Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Mar 8, 2024

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327631: Update IANA Language Subtag Registry to Version 2024-03-07

Reviewed-by: naoto, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • 33aa4b2: 8256314: JVM TI GetCurrentContendedMonitor is implemented incorrectly
  • 87b40c6: 8327167: Clarify the handling of Leap year by Calendar
  • 6efdaf8: 8326908: DecimalFormat::toPattern throws OutOfMemoryError when pattern is empty string
  • c4845f0: 8317431: Implement simpler Comparator when building certification paths
  • 585a958: 8327675: jspawnhelper should be built on all unix platforms
  • 06f7bb5: 8327677: Parallel: Remove unused ParallelCompactData::clear
  • 1877a48: 8308745: ObjArrayKlass::allocate_objArray_klass may call into java while holding a lock
  • 997e615: 8322943: runtime/CompressedOops/CompressedClassPointers.java fails on AIX
  • 27a03e0: 8327218: Add an ability to specify modules which should have native access enabled
  • d0d4912: 8326096: Deprecate getTotalIn, getTotalOut methods of java.util.zip.Inflater, java.util.zip.Deflater
  • ... and 7 more: https://git.openjdk.org/jdk/compare/972e81d1adb232b02114a5260d06144eb5b08849...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 8, 2024
@justin-curtis-lu
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 12, 2024

Going to push as commit d5b95a0.
Since your change was applied there have been 62 commits pushed to the master branch:

  • 966a42f: 8324868: debug agent does not properly handle interrupts of a virtual thread
  • 22f10e0: 8327856: Convert applet test SpanishDiacriticsTest.java to a main program
  • 7283c8b: 8327972: Convert java/awt/FileDialog/SaveFileNameOverrideTest/SaveFileNameOverrideTest.html applet test to main
  • 30249c4: 8327838: Convert java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main
  • 94b4ed5: 8327096: (fc) java/nio/channels/FileChannel/Size.java fails on partition incapable of creating large files
  • b9c3dc3: 8327738: Remove unused internal method sun.n.w.p.h.HttpURLConnection.setDefaultAuthenticator
  • 5b41466: 8327729: Remove deprecated xxxObject methods from jdk.internal.misc.Unsafe
  • 313e814: 8324682: Remove redefinition of NULL for XLC compiler
  • 8a3bdd5: 8327995: Remove unused Unused_Variable
  • 201042f: 8327487: Further augment WorstCaseTests with more cases
  • ... and 52 more: https://git.openjdk.org/jdk/compare/972e81d1adb232b02114a5260d06144eb5b08849...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 12, 2024
@openjdk openjdk bot closed this Mar 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 12, 2024
@openjdk
Copy link

openjdk bot commented Mar 12, 2024

@justin-curtis-lu Pushed as commit d5b95a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
3 participants